[Fiber] Remove the digest property from errorInfo passed to onRecover…

…ableError (#28222) Removes the digest property from errorInfo passed to onRecoverableError when handling an error propagated from the server. Previously we warned in Dev but still provided the digest on the errorInfo object. This change removes digest from error info but continues to warn if it is accessed. The reason for retaining the warning is the version with the warning was not released as stable but we will include this deprecated removal in our next major so we should communicate this change at runtime. DiffTrain build for commit 299a9c0.
facebook · Mar 28, 2024 · d9c978d · d9c978d
1 parent 84addaa
commit d9c978d
Show file tree

Hide file tree

Showing 10 changed files with 167 additions and 167 deletions.
diff --git a/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js b/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<398013076b718065eff718ae9cda9bc9>>
+ * @generated SignedSource<<9163dccf70951cc5d1bae88f3bef99d1>>
  */
 
 "use strict";
@@ -24249,10 +24249,7 @@ if (__DEV__) {
 
         for (var i = 0; i < recoverableErrors.length; i++) {
           var recoverableError = recoverableErrors[i];
-          var errorInfo = makeErrorInfo(
-            recoverableError.digest,
-            recoverableError.stack
-          );
+          var errorInfo = makeErrorInfo(recoverableError.stack);
           onRecoverableError(recoverableError.value, errorInfo);
         }
       } // If the passive effects are the result of a discrete render, flush them
@@ -24304,26 +24301,35 @@ if (__DEV__) {
       return null;
     }
 
-    function makeErrorInfo(digest, componentStack) {
+    function makeErrorInfo(componentStack) {
       {
         var errorInfo = {
-          componentStack: componentStack,
-          digest: digest
+          componentStack: componentStack
         };
-        Object.defineProperty(errorInfo, "digest", {
-          configurable: false,
-          enumerable: true,
-          get: function () {
-            error(
-              'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
-                " This property is deprecated and will be removed in a future version of React." +
-                " To access the digest of an Error look for this property on the Error instance itself."
-            );
+        return new Proxy(errorInfo, {
+          get: function (target, prop, receiver) {
+            if (prop === "digest") {
+              error(
+                'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
+                  " This property is no longer provided as part of errorInfo but can be accessed as a property" +
+                  " of the Error instance itself."
+              );
+            }
+
+            return Reflect.get(target, prop, receiver);
+          },
+          has: function (target, prop) {
+            if (prop === "digest") {
+              error(
+                'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
+                  " This property is no longer provided as part of errorInfo but can be accessed as a property" +
+                  " of the Error instance itself."
+              );
+            }
 
-            return digest;
+            return Reflect.has(target, prop);
           }
         });
-        return errorInfo;
       }
     }
 
@@ -26240,7 +26246,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "19.0.0-canary-32f0e114";
+    var ReactVersion = "19.0.0-canary-9cf58c47";
 
     // Might add PROFILE later.
 

diff --git a/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js b/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<0ee47dc3b016f4afd98141a3877b7155>>
+ * @generated SignedSource<<7497ca87141c739d6dc547bd8e1e7548>>
  */
 
 "use strict";
@@ -8282,10 +8282,7 @@ function commitRootImpl(
       finishedWork++
     )
       (remainingLanes = recoverableErrors[finishedWork]),
-        (transitions = {
-          digest: remainingLanes.digest,
-          componentStack: remainingLanes.stack
-        }),
+        (transitions = { componentStack: remainingLanes.stack }),
         renderPriorityLevel(remainingLanes.value, transitions);
   0 !== (pendingPassiveEffectsLanes & 3) &&
     0 !== root.tag &&
@@ -9180,19 +9177,19 @@ function wrapFiber(fiber) {
     fiberToWrapper.set(fiber, wrapper));
   return wrapper;
 }
-var devToolsConfig$jscomp$inline_1010 = {
+var devToolsConfig$jscomp$inline_1009 = {
   findFiberByHostInstance: function () {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "19.0.0-canary-c99426f3",
+  version: "19.0.0-canary-98ee7ddb",
   rendererPackageName: "react-test-renderer"
 };
-var internals$jscomp$inline_1198 = {
-  bundleType: devToolsConfig$jscomp$inline_1010.bundleType,
-  version: devToolsConfig$jscomp$inline_1010.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1010.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1010.rendererConfig,
+var internals$jscomp$inline_1197 = {
+  bundleType: devToolsConfig$jscomp$inline_1009.bundleType,
+  version: devToolsConfig$jscomp$inline_1009.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1009.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1009.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9209,26 +9206,26 @@ var internals$jscomp$inline_1198 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1010.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1009.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-c99426f3"
+  reconcilerVersion: "19.0.0-canary-98ee7ddb"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1199 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1198 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1199.isDisabled &&
-    hook$jscomp$inline_1199.supportsFiber
+    !hook$jscomp$inline_1198.isDisabled &&
+    hook$jscomp$inline_1198.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1199.inject(
-        internals$jscomp$inline_1198
+      (rendererID = hook$jscomp$inline_1198.inject(
+        internals$jscomp$inline_1197
       )),
-        (injectedHook = hook$jscomp$inline_1199);
+        (injectedHook = hook$jscomp$inline_1198);
     } catch (err) {}
 }
 exports._Scheduler = Scheduler;

diff --git a/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<41c82c8e66afe030207944ff087399ac>>
+ * @generated SignedSource<<cd4c154717168d88a82e949aca92f93f>>
  */
 
 "use strict";
@@ -8648,10 +8648,7 @@ function commitRootImpl(
       finishedWork++
     )
       (remainingLanes = recoverableErrors[finishedWork]),
-        (transitions = {
-          digest: remainingLanes.digest,
-          componentStack: remainingLanes.stack
-        }),
+        (transitions = { componentStack: remainingLanes.stack }),
         renderPriorityLevel(remainingLanes.value, transitions);
   0 !== (pendingPassiveEffectsLanes & 3) &&
     0 !== root.tag &&
@@ -9606,19 +9603,19 @@ function wrapFiber(fiber) {
     fiberToWrapper.set(fiber, wrapper));
   return wrapper;
 }
-var devToolsConfig$jscomp$inline_1053 = {
+var devToolsConfig$jscomp$inline_1052 = {
   findFiberByHostInstance: function () {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "19.0.0-canary-58a5689a",
+  version: "19.0.0-canary-cb1ca1a0",
   rendererPackageName: "react-test-renderer"
 };
-var internals$jscomp$inline_1239 = {
-  bundleType: devToolsConfig$jscomp$inline_1053.bundleType,
-  version: devToolsConfig$jscomp$inline_1053.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1053.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1053.rendererConfig,
+var internals$jscomp$inline_1238 = {
+  bundleType: devToolsConfig$jscomp$inline_1052.bundleType,
+  version: devToolsConfig$jscomp$inline_1052.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1052.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1052.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9635,26 +9632,26 @@ var internals$jscomp$inline_1239 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1053.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1052.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-58a5689a"
+  reconcilerVersion: "19.0.0-canary-cb1ca1a0"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1240 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1239 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1240.isDisabled &&
-    hook$jscomp$inline_1240.supportsFiber
+    !hook$jscomp$inline_1239.isDisabled &&
+    hook$jscomp$inline_1239.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1240.inject(
-        internals$jscomp$inline_1239
+      (rendererID = hook$jscomp$inline_1239.inject(
+        internals$jscomp$inline_1238
       )),
-        (injectedHook = hook$jscomp$inline_1240);
+        (injectedHook = hook$jscomp$inline_1239);
     } catch (err) {}
 }
 exports._Scheduler = Scheduler;

diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-e10a7b5cd541882a78ff659147c1a0294413ccb0
+299a9c0598576f7dba170771b1c0b821281b1e15
diff --git a/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<9c81454fac04a284791d0ad56825d16e>>
+ * @generated SignedSource<<a65269663102fa977c930ff006dd7573>>
  */
 
 "use strict";
@@ -28415,10 +28415,7 @@ to return true:wantsResponderID|                            |
 
         for (var i = 0; i < recoverableErrors.length; i++) {
           var recoverableError = recoverableErrors[i];
-          var errorInfo = makeErrorInfo(
-            recoverableError.digest,
-            recoverableError.stack
-          );
+          var errorInfo = makeErrorInfo(recoverableError.stack);
           onRecoverableError(recoverableError.value, errorInfo);
         }
       } // If the passive effects are the result of a discrete render, flush them
@@ -28475,26 +28472,35 @@ to return true:wantsResponderID|                            |
       return null;
     }
 
-    function makeErrorInfo(digest, componentStack) {
+    function makeErrorInfo(componentStack) {
       {
         var errorInfo = {
-          componentStack: componentStack,
-          digest: digest
+          componentStack: componentStack
         };
-        Object.defineProperty(errorInfo, "digest", {
-          configurable: false,
-          enumerable: true,
-          get: function () {
-            error(
-              'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
-                " This property is deprecated and will be removed in a future version of React." +
-                " To access the digest of an Error look for this property on the Error instance itself."
-            );
+        return new Proxy(errorInfo, {
+          get: function (target, prop, receiver) {
+            if (prop === "digest") {
+              error(
+                'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
+                  " This property is no longer provided as part of errorInfo but can be accessed as a property" +
+                  " of the Error instance itself."
+              );
+            }
+
+            return Reflect.get(target, prop, receiver);
+          },
+          has: function (target, prop) {
+            if (prop === "digest") {
+              error(
+                'You are accessing "digest" from the errorInfo object passed to onRecoverableError.' +
+                  " This property is no longer provided as part of errorInfo but can be accessed as a property" +
+                  " of the Error instance itself."
+              );
+            }
 
-            return digest;
+            return Reflect.has(target, prop);
           }
         });
-        return errorInfo;
       }
     }
 
@@ -30571,7 +30577,7 @@ to return true:wantsResponderID|                            |
       return root;
     }
 
-    var ReactVersion = "19.0.0-canary-1f40d31c";
+    var ReactVersion = "19.0.0-canary-9d775306";
 
     function createPortal$1(
       children,
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		e10a7b5cd541882a78ff659147c1a0294413ccb0
		299a9c0598576f7dba170771b1c0b821281b1e15