Include component stack in 'act(...)' warning (#14855)

* add a component stack trace to the act() warning * pass tests * nit
facebook · Feb 14, 2019 · c555c00 · c555c00
1 parent ff188d6
commit c555c00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactTestUtils-test.js b/packages/react-dom/src/__tests__/ReactTestUtils-test.js
@@ -634,10 +634,9 @@ describe('ReactTestUtils', () => {
       button.dispatchEvent(new MouseEvent('click', {bubbles: true}));
     });
     expect(button.innerHTML).toBe('2');
-    expect(() => setValueRef(1)).toWarnDev(
-      ['An update to App inside a test was not wrapped in act(...).'],
-      {withoutStack: 1},
-    );
+    expect(() => setValueRef(1)).toWarnDev([
+      'An update to App inside a test was not wrapped in act(...).',
+    ]);
     document.body.removeChild(container);
   });
 

diff --git a/packages/react-reconciler/src/ReactFiberScheduler.js b/packages/react-reconciler/src/ReactFiberScheduler.js
@@ -1839,8 +1839,10 @@ export function warnIfNotCurrentlyBatchingInDev(fiber: Fiber): void {
           '});\n' +
           '/* assert on the output */\n\n' +
           "This ensures that you're testing the behavior the user would see in the browser." +
-          ' Learn more at https://fb.me/react-wrap-tests-with-act',
+          ' Learn more at https://fb.me/react-wrap-tests-with-act' +
+          '%s',
         getComponentName(fiber.type),
+        getStackByFiberInDevAndProd(fiber),
       );
     }
   }