Don't suppress jsdom error reporting in our tests (#13401)

* Don't suppress jsdom error reporting * Address review
facebook · Aug 15, 2018 · b2adcfb · b2adcfb
1 parent 69e2a0d
commit b2adcfb
Show file tree

Hide file tree

Showing 8 changed files with 259 additions and 225 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactErrorLoggingRecovery-test.js b/packages/react-dom/src/__tests__/ReactErrorLoggingRecovery-test.js
@@ -19,12 +19,6 @@ if (global.window) {
 const React = require('react');
 const ReactDOM = require('react-dom');
 
-// Unlike other tests, we want to enable error logging.
-// Note this is not a real Error prototype property,
-// it's only set in our Jest environment.
-// eslint-disable-next-line no-extend-native
-Error.prototype.suppressReactErrorLogging = false;
-
 // Initialize JSDOM separately.
 // We don't use our normal JSDOM setup because we want to load React first.
 const {JSDOM} = require('jsdom');

diff --git a/packages/react-reconciler/src/ReactFiberErrorLogger.js b/packages/react-reconciler/src/ReactFiberErrorLogger.js
@@ -21,11 +21,6 @@ export function logCapturedError(capturedError: CapturedError): void {
   }
 
   const error = (capturedError.error: any);
-  const suppressLogging = error && error.suppressReactErrorLogging;
-  if (suppressLogging) {
-    return;
-  }
-
   if (__DEV__) {
     const {
       componentName,

diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalErrorLogging-test.internal.js b/packages/react-reconciler/src/__tests__/ReactIncrementalErrorLogging-test.internal.js