Skip to content

Commit

Permalink
Remove excess validation (#27223)
Browse files Browse the repository at this point in the history
stacked on #27222

When I initially developed Float I was trying to be extremely clever in
how to explain when there are mismatching Resource instances. I still
think that we should do some kind of validation here but I want to
implement something much simpler. In practice there are not many cases
where you would accidentally create the same resource twice but with
differing props. Since I am going to land `preloadModule` and
`preinitModule` soon and I want to avoid adding to the overly complex
dev validation there I am going to remove it now and add something later
that is simplified.

DiffTrain build for [5ea1397](5ea1397)
  • Loading branch information
gnoff committed Aug 14, 2023
1 parent 3ffb40a commit 9f4e34b
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 2,676 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5ad8ef57729fa4a57aeec3f9b0516325248dba85
5ea1397b2b62875dfb521cf8de0efcc15d0df797
Loading

0 comments on commit 9f4e34b

Please sign in to comment.