ReactFiberHydrationWarning in react-reconciler: pretty attribute names

Print the extra attribute names array nicer, with a space after comma. The default array toString was used implicitly before.
facebook · Oct 1, 2018 · 9c8093f · 9c8093f
1 parent c0b7780
commit 9c8093f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactMount-test.js b/packages/react-dom/src/__tests__/ReactMount-test.js
@@ -552,7 +552,7 @@ describe('ReactMount', () => {
         div,
       ),
     ).toWarnDev(
-      'Warning: Extra attributes from the server: data-ssr-extra-prop,data-ssr-extra-prop-2\n' +
+      'Warning: Extra attributes from the server: data-ssr-extra-prop, data-ssr-extra-prop-2\n' +
         '    in div (at **)',
     );
   });

diff --git a/packages/react-reconciler/src/ReactFiberHydrationWarning.js b/packages/react-reconciler/src/ReactFiberHydrationWarning.js
@@ -624,7 +624,7 @@ function warnForExtraAttributes(attributeNames: Set<string>) {
     names.push(name);
   });
   // TODO: As we're here in the terminology of universal hydration, should we stop saying 'from the server'?
-  warning(false, 'Extra attributes from the server: %s', names);
+  warning(false, 'Extra attributes from the server: %s', names.join(', '));
 }
 
 function warnForDeletedHydratableInstance(