Skip to content

Commit

Permalink
[Flight][Reply] Close Response after creating root chunk (#27634)
Browse files Browse the repository at this point in the history
creating the root after closing the response can lead to a promise that
never rejects. This is not intended use of the decodeReply API but if
pathalogical cases where you pass a raw FormData into this fucntion with
no zero chunk it can hang forever. This reordering causes a connection
error instead

---------

Co-authored-by: Zack Tanner <[email protected]>

DiffTrain build for commit 08a3953.
  • Loading branch information
gnoff committed Nov 1, 2023
1 parent 3f8dff1 commit 956de72
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24887,7 +24887,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-ca16c2635-20231031";
var ReactVersion = "18.3.0-canary-08a39539f-20231031";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9025,7 +9025,7 @@ var devToolsConfig$jscomp$inline_1032 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-ca16c2635-20231031",
version: "18.3.0-canary-08a39539f-20231031",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1225 = {
Expand Down Expand Up @@ -9056,7 +9056,7 @@ var internals$jscomp$inline_1225 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-ca16c2635-20231031"
reconcilerVersion: "18.3.0-canary-08a39539f-20231031"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1226 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9451,7 +9451,7 @@ var devToolsConfig$jscomp$inline_1074 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-ca16c2635-20231031",
version: "18.3.0-canary-08a39539f-20231031",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1266 = {
Expand Down Expand Up @@ -9482,7 +9482,7 @@ var internals$jscomp$inline_1266 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-ca16c2635-20231031"
reconcilerVersion: "18.3.0-canary-08a39539f-20231031"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1267 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-ca16c2635-20231031";
var ReactVersion = "18.3.0-canary-08a39539f-20231031";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-ca16c2635-20231031";
exports.version = "18.3.0-canary-08a39539f-20231031";
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-ca16c2635-20231031";
exports.version = "18.3.0-canary-08a39539f-20231031";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ca16c26356221a4b52185d7425d77675f0307250
08a39539fc6922cdb9e2405029127a1911b1b809

0 comments on commit 956de72

Please sign in to comment.