Skip to content

Commit

Permalink
Fail yarn build if any bundle fails to build (#26207)
Browse files Browse the repository at this point in the history
## Summary

`yarn build` would previously still exit with zero exit code hiding
build errors such as
https://app.circleci.com/pipelines/github/facebook/react/38609/workflows/62a73635-3bf3-4264-8c48-a61844a27764/jobs/630503/parallel-runs/11?filterBy=ALL&invite=true#step-105-17.
These issues are still surfaced due to missing size bot artifacts but
the overall PR status would still be green which we don't want.

Now we just exit with the same exit has a the process of a single build
if it's non-zero.

## How did you test this change?

- [x] fails based on the parent of
62e6c46:
https://app.circleci.com/pipelines/github/facebook/react/38681/workflows/654c68ed-cebc-48d4-a156-bac719772f6f/jobs/632166
- [x] passes based on `main`

DiffTrain build for commit bb1e3d0.
  • Loading branch information
eps1lon committed Feb 20, 2023
1 parent 3484cc2 commit 8a67cf0
Show file tree
Hide file tree
Showing 28 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
62e6c4612ec704cf07c99b318bc8f26d3ec3f588
bb1e3d0e19f1e36ecb5b9e58d40bbf59fa220b73
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
62e6c4612ec704cf07c99b318bc8f26d3ec3f588
bb1e3d0e19f1e36ecb5b9e58d40bbf59fa220b73
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

// ATTENTION
// When adding new symbols to this file,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-62e6c4612-20230220";
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-62e6c4612-20230220";
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-62e6c4612-20230220";
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-62e6c4612-20230220";
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-62e6c4612-20230220",
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1301 = {
Expand Down Expand Up @@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-62e6c4612-20230220",
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1281 = {
Expand Down Expand Up @@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -41996,7 +41996,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -41600,7 +41600,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -15469,7 +15469,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1742 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-62e6c4612-20230220",
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2109 = {
Expand Down Expand Up @@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -14998,7 +14998,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1701 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-62e6c4612-20230220",
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2073 = {
Expand Down Expand Up @@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -16239,7 +16239,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-62e6c4612-20230220",
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -15758,7 +15758,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-62e6c4612-20230220",
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

// This refers to a WWW module.
var warningWWW = require("warning");
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-62e6c4612-20230220";
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-62e6c4612-20230220";
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -31233,7 +31233,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

function createPortal$1(
children,
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMTesting-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -37624,7 +37624,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

function createPortal$1(
children,
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -11541,7 +11541,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1536 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-62e6c4612-20230220",
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2059 = {
Expand Down Expand Up @@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactDOMTesting-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -13856,7 +13856,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1653 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-62e6c4612-20230220",
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2033 = {
Expand Down Expand Up @@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-62e6c4612-20230220"
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-62e6c4612-20230220";
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";

// Might add PROFILE later.

Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactTestRenderer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-62e6c4612-20230220";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";

// Might add PROFILE later.

Expand Down

0 comments on commit 8a67cf0

Please sign in to comment.