Changed componentDidCatch no-state-update warning message to remove m…

…ention of throw I think this is confusing because it implies that gDSFE can throw and cDC will still be called, when that is not the case (because cDC is a commit phase lifecycle- and if gDSFE rethrows, the boundary in question will never mount and the commit phase menthods it defines will not be called.
facebook · Sep 28, 2018 · 54f637f · 54f637f
1 parent 9943c6c
commit 54f637f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js b/packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js
@@ -2111,8 +2111,7 @@ describe('ReactErrorBoundaries', () => {
       );
     }).toWarnDev(
       'InvalidErrorBoundary: Error boundaries should implement getDerivedStateFromError(). ' +
-        'In that method, return a state update to display an error message or fallback UI, ' +
-        'or rethrow the error to let parent components handle it',
+        'In that method, return a state update to display an error message or fallback UI.',
       {withoutStack: true},
     );
     expect(container.textContent).toBe('');

diff --git a/packages/react-reconciler/src/ReactFiberUnwindWork.js b/packages/react-reconciler/src/ReactFiberUnwindWork.js
@@ -135,8 +135,7 @@ function createClassErrorUpdate(
           warningWithoutStack(
             fiber.expirationTime === Sync,
             '%s: Error boundaries should implement getDerivedStateFromError(). ' +
-              'In that method, return a state update to display an error message or fallback UI, ' +
-              'or rethrow the error to let parent components handle it.',
+              'In that method, return a state update to display an error message or fallback UI.',
             getComponentName(fiber.type) || 'Unknown',
           );
         }