Skip to content

Commit

Permalink
Remove excess validation (#27223)
Browse files Browse the repository at this point in the history
stacked on #27222

When I initially developed Float I was trying to be extremely clever in
how to explain when there are mismatching Resource instances. I still
think that we should do some kind of validation here but I want to
implement something much simpler. In practice there are not many cases
where you would accidentally create the same resource twice but with
differing props. Since I am going to land `preloadModule` and
`preinitModule` soon and I want to avoid adding to the overly complex
dev validation there I am going to remove it now and add something later
that is simplified.

DiffTrain build for commit 5ea1397.
  • Loading branch information
gnoff committed Aug 14, 2023
1 parent e94b4cb commit 4e27e04
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23961,7 +23961,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-5ad8ef577-20230814";
var ReactVersion = "18.3.0-canary-5ea1397b2-20230814";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8615,7 +8615,7 @@ var devToolsConfig$jscomp$inline_1029 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-5ad8ef577-20230814",
version: "18.3.0-canary-5ea1397b2-20230814",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1228 = {
Expand Down Expand Up @@ -8646,7 +8646,7 @@ var internals$jscomp$inline_1228 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-5ad8ef577-20230814"
reconcilerVersion: "18.3.0-canary-5ea1397b2-20230814"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1229 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9041,7 +9041,7 @@ var devToolsConfig$jscomp$inline_1071 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-5ad8ef577-20230814",
version: "18.3.0-canary-5ea1397b2-20230814",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1269 = {
Expand Down Expand Up @@ -9072,7 +9072,7 @@ var internals$jscomp$inline_1269 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-5ad8ef577-20230814"
reconcilerVersion: "18.3.0-canary-5ea1397b2-20230814"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1270 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-5ad8ef577-20230814";
var ReactVersion = "18.3.0-canary-5ea1397b2-20230814";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -616,4 +616,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-5ad8ef577-20230814";
exports.version = "18.3.0-canary-5ea1397b2-20230814";
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-5ad8ef577-20230814";
exports.version = "18.3.0-canary-5ea1397b2-20230814";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5ad8ef57729fa4a57aeec3f9b0516325248dba85
5ea1397b2b62875dfb521cf8de0efcc15d0df797

0 comments on commit 4e27e04

Please sign in to comment.