Use string concat in renderToString

I think this might be faster. We could probably use a combination of this technique in the stream too to lower the overhead.
facebook · Apr 26, 2021 · 400286f · 400286f
1 parent c07c626
commit 400286f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/react-dom/src/server/ReactDOMLegacyServerBrowser.js b/packages/react-dom/src/server/ReactDOMLegacyServerBrowser.js
@@ -38,11 +38,11 @@ function renderToString(
 ): string {
   let didFatal = false;
   let fatalError = null;
-  const result = [];
+  const result = '';
   const destination = {
     push(chunk) {
-      if (chunk) {
-        result.push(chunk);
+      if (chunk !== null) {
+        result += chunk;
       }
       return true;
     },
@@ -69,7 +69,7 @@ function renderToString(
   if (didFatal) {
     throw fatalError;
   }
-  return result.join('');
+  return result;
 }
 
 function renderToNodeStream() {