Skip to content

Commit

Permalink
Tweak error message for "Should have a queue"
Browse files Browse the repository at this point in the history
This can happen if you call Hooks conditionally. If someone runs into this error and that isn't the case, I imagine they'll still file an issue.
  • Loading branch information
sophiebits committed May 28, 2024
1 parent a9a0106 commit 34cf654
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions packages/react-reconciler/src/ReactFiberHooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,8 @@ function updateReducerImpl<S, A>(

if (queue === null) {
throw new Error(
'Should have a queue. This is likely a bug in React. Please file an issue.',
'Should have a queue. You are likely calling Hooks conditionally, ' +
'which is not allowed. (https://react.dev/link/invalid-hook-call)',
);
}

Expand Down Expand Up @@ -1506,7 +1507,8 @@ function rerenderReducer<S, I, A>(

if (queue === null) {
throw new Error(
'Should have a queue. This is likely a bug in React. Please file an issue.',
'Should have a queue. You are likely calling Hooks conditionally, ' +
'which is not allowed. (https://react.dev/link/invalid-hook-call)',
);
}

Expand Down
2 changes: 1 addition & 1 deletion scripts/error-codes/codes.json
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@
"308": "Context can only be read while React is rendering. In classes, you can read it in the render method or getDerivedStateFromProps. In function components, you can read it directly in the function body, but not inside Hooks like useReducer() or useMemo().",
"309": "Function components cannot have string refs. We recommend using useRef() instead. Learn more about using refs safely here: https://react.dev/link/strict-mode-string-ref",
"310": "Rendered more hooks than during the previous render.",
"311": "Should have a queue. This is likely a bug in React. Please file an issue.",
"311": "Should have a queue. You are likely calling Hooks conditionally, which is not allowed. (https://react.dev/link/invalid-hook-call)",
"312": "Rendered more hooks than during the previous render",
"313": "Unknown priority level. This error is likely caused by a bug in React. Please file an issue.",
"314": "Pinged unknown suspense boundary type. This is probably a bug in React.",
Expand Down

0 comments on commit 34cf654

Please sign in to comment.