ESLint upgrade to use hermes-eslint (#25915)

Hermes parser is the preferred parser for Flow code going forward. We need to upgrade to this parser to support new Flow syntax like function `this` context type annotations or `ObjectType['prop']` syntax. Unfortunately, there's quite a few upgrades here to make it work somehow (dependencies between the changes) - ~Upgrade `eslint` to `8.*`~ reverted this as the React eslint plugin tests depend on the older version and there's a [yarn bug](yarnpkg/yarn#6285) that prevents `devDependencies` and `peerDependencies` to different versions. - Remove `eslint-config-fbjs` preset dependency and inline the rules, imho this makes it a lot clearer what the rules are. - Remove the turned off `jsx-a11y/*` rules and it's dependency instead of inlining those from the `fbjs` config. - Update parser and dependency from `babel-eslint` to `hermes-eslint`. - `ft-flow/no-unused-expressions` rule replaces `no-unused-expressions` which now allows standalone type asserts, e.g. `(foo: number);` - Bunch of globals added to the eslint config - Disabled `no-redeclare`, seems like the eslint upgrade started making this more precise and warn against re-defined globals like `__EXPERIMENTAL__` (in rollup scripts) or `fetch` (when importing fetch from node-fetch). - Minor lint fixes like duplicate keys in objects.
facebook · Dec 20, 2022 · 2b1fb91 · 2b1fb91
1 parent fabef7a
commit 2b1fb91
Show file tree

Hide file tree

Showing 36 changed files with 604 additions and 260 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,23 +8,26 @@ const {
 const restrictedGlobals = require('confusing-browser-globals');
 
 const OFF = 0;
+const WARNING = 1;
 const ERROR = 2;
 
 module.exports = {
-  extends: ['fbjs', 'prettier'],
+  extends: ['prettier'],
 
   // Stop ESLint from looking for a configuration file in parent folders
   root: true,
 
   plugins: [
+    'babel',
+    'ft-flow',
     'jest',
     'no-for-of-loops',
     'no-function-declare-after-return',
     'react',
     'react-internal',
   ],
 
-  parser: 'babel-eslint',
+  parser: 'hermes-eslint',
   parserOptions: {
     ecmaVersion: 9,
     sourceType: 'script',
@@ -33,6 +36,190 @@ module.exports = {
   // We're stricter than the default config, mostly. We'll override a few rules
   // and then enable some React specific ones.
   rules: {
+    'ft-flow/array-style-complex-type': [OFF, 'verbose'],
+    'ft-flow/array-style-simple-type': [OFF, 'verbose'], // TODO should be WARNING
+    'ft-flow/boolean-style': ERROR,
+    'ft-flow/no-dupe-keys': ERROR,
+    'ft-flow/no-primitive-constructor-types': ERROR,
+    'ft-flow/no-types-missing-file-annotation': OFF, // TODO should be ERROR
+    'ft-flow/no-unused-expressions': ERROR,
+    // 'ft-flow/no-weak-types': WARNING,
+    // 'ft-flow/require-valid-file-annotation': ERROR,
+
+    'no-cond-assign': OFF,
+    'no-constant-condition': OFF,
+    'no-control-regex': OFF,
+    'no-debugger': ERROR,
+    'no-dupe-args': ERROR,
+    'no-dupe-keys': ERROR,
+    'no-duplicate-case': WARNING,
+    'no-empty-character-class': WARNING,
+    'no-empty': OFF,
+    'no-ex-assign': WARNING,
+    'no-extra-boolean-cast': WARNING,
+    'no-func-assign': ERROR,
+    'no-invalid-regexp': WARNING,
+    'no-irregular-whitespace': WARNING,
+    'no-negated-in-lhs': ERROR,
+    'no-obj-calls': ERROR,
+    'no-regex-spaces': WARNING,
+    'no-sparse-arrays': ERROR,
+    'no-unreachable': ERROR,
+    'use-isnan': ERROR,
+    'valid-jsdoc': OFF,
+    'block-scoped-var': OFF,
+    complexity: OFF,
+    'default-case': OFF,
+    'guard-for-in': OFF,
+    'no-alert': OFF,
+    'no-caller': ERROR,
+    'no-case-declarations': OFF,
+    'no-div-regex': OFF,
+    'no-else-return': OFF,
+    'no-empty-pattern': WARNING,
+    'no-eq-null': OFF,
+    'no-eval': ERROR,
+    'no-extend-native': WARNING,
+    'no-extra-bind': WARNING,
+    'no-fallthrough': WARNING,
+    'no-implicit-coercion': OFF,
+    'no-implied-eval': ERROR,
+    'no-invalid-this': OFF,
+    'no-iterator': OFF,
+    'no-labels': [ERROR, {allowLoop: true, allowSwitch: true}],
+    'no-lone-blocks': WARNING,
+    'no-loop-func': OFF,
+    'no-magic-numbers': OFF,
+    'no-multi-str': ERROR,
+    'no-native-reassign': [ERROR, {exceptions: ['Map', 'Set']}],
+    'no-new-func': ERROR,
+    'no-new': WARNING,
+    'no-new-wrappers': WARNING,
+    'no-octal-escape': WARNING,
+    'no-octal': WARNING,
+    'no-param-reassign': OFF,
+    'no-process-env': OFF,
+    'no-proto': ERROR,
+    'no-redeclare': OFF, // TODO should be WARNING?
+    'no-return-assign': OFF,
+    'no-script-url': ERROR,
+    'no-self-compare': WARNING,
+    'no-sequences': WARNING,
+    'no-throw-literal': ERROR,
+    'no-useless-call': WARNING,
+    'no-void': OFF,
+    'no-warning-comments': OFF,
+    'no-with': OFF,
+    radix: WARNING,
+    'vars-on-top': OFF,
+    yoda: OFF,
+    'init-declarations': OFF,
+    'no-catch-shadow': ERROR,
+    'no-delete-var': ERROR,
+    'no-label-var': WARNING,
+    'no-shadow-restricted-names': WARNING,
+    'no-undef-init': OFF,
+    'no-undef': ERROR,
+    'no-undefined': OFF,
+    'callback-return': OFF,
+    'global-require': OFF,
+    'handle-callback-err': OFF,
+    'no-mixed-requires': OFF,
+    'no-new-require': OFF,
+    'no-path-concat': OFF,
+    'no-process-exit': OFF,
+    'no-restricted-modules': OFF,
+    'no-sync': OFF,
+    camelcase: [OFF, {properties: 'always'}],
+    'consistent-this': [OFF, 'self'],
+    'func-names': OFF,
+    'func-style': [OFF, 'declaration'],
+    'id-length': OFF,
+    'id-match': OFF,
+    'max-depth': OFF,
+    'max-nested-callbacks': OFF,
+    'max-params': OFF,
+    'max-statements': OFF,
+    'new-cap': OFF,
+    'newline-after-var': OFF,
+    'no-array-constructor': ERROR,
+    'no-continue': OFF,
+    'no-inline-comments': OFF,
+    'no-lonely-if': OFF,
+    'no-negated-condition': OFF,
+    'no-nested-ternary': OFF,
+    'no-new-object': WARNING,
+    'no-plusplus': OFF,
+    'no-ternary': OFF,
+    'no-underscore-dangle': OFF,
+    'no-unneeded-ternary': WARNING,
+    'one-var': [WARNING, {initialized: 'never'}],
+    'operator-assignment': [WARNING, 'always'],
+    'require-jsdoc': OFF,
+    'sort-vars': OFF,
+    'spaced-comment': [
+      OFF,
+      'always',
+      {exceptions: ['jshint', 'jslint', 'eslint', 'global']},
+    ],
+    'constructor-super': ERROR,
+    'no-class-assign': WARNING,
+    'no-const-assign': ERROR,
+    'no-dupe-class-members': ERROR,
+    'no-this-before-super': ERROR,
+    'object-shorthand': OFF,
+    'prefer-const': OFF,
+    'prefer-spread': OFF,
+    'prefer-reflect': OFF,
+    'prefer-template': OFF,
+    'require-yield': OFF,
+    'babel/generator-star-spacing': OFF,
+    'babel/new-cap': OFF,
+    'babel/array-bracket-spacing': OFF,
+    'babel/object-curly-spacing': OFF,
+    'babel/object-shorthand': OFF,
+    'babel/arrow-parens': OFF,
+    'babel/no-await-in-loop': OFF,
+    'babel/flow-object-type': OFF,
+    'react/display-name': OFF,
+    'react/forbid-prop-types': OFF,
+    'react/jsx-closing-bracket-location': OFF,
+    'react/jsx-curly-spacing': OFF,
+    'react/jsx-equals-spacing': WARNING,
+    'react/jsx-filename-extension': OFF,
+    'react/jsx-first-prop-new-line': OFF,
+    'react/jsx-handler-names': OFF,
+    'react/jsx-indent': OFF,
+    'react/jsx-indent-props': OFF,
+    'react/jsx-key': OFF,
+    'react/jsx-max-props-per-line': OFF,
+    'react/jsx-no-bind': OFF,
+    'react/jsx-no-duplicate-props': ERROR,
+    'react/jsx-no-literals': OFF,
+    'react/jsx-no-target-blank': OFF,
+    'react/jsx-pascal-case': OFF,
+    'react/jsx-sort-props': OFF,
+    'react/jsx-uses-vars': ERROR,
+    'react/no-comment-textnodes': OFF,
+    'react/no-danger': OFF,
+    'react/no-deprecated': OFF,
+    'react/no-did-mount-set-state': OFF,
+    'react/no-did-update-set-state': OFF,
+    'react/no-direct-mutation-state': OFF,
+    'react/no-multi-comp': OFF,
+    'react/no-render-return-value': OFF,
+    'react/no-set-state': OFF,
+    'react/no-string-refs': OFF,
+    'react/no-unknown-property': OFF,
+    'react/prefer-es6-class': OFF,
+    'react/prefer-stateless-function': OFF,
+    'react/prop-types': OFF,
+    'react/require-extension': OFF,
+    'react/require-optimization': OFF,
+    'react/require-render-return': OFF,
+    'react/sort-comp': OFF,
+    'react/sort-prop-types': OFF,
+
     'accessor-pairs': OFF,
     'brace-style': [ERROR, '1tbs'],
     'consistent-return': OFF,
@@ -51,7 +238,6 @@ module.exports = {
     'no-restricted-globals': [ERROR].concat(restrictedGlobals),
     'no-restricted-syntax': [ERROR, 'WithStatement'],
     'no-shadow': ERROR,
-    'no-unused-expressions': ERROR,
     'no-unused-vars': [ERROR, {args: 'none'}],
     'no-use-before-define': OFF,
     'no-useless-concat': OFF,
@@ -74,8 +260,6 @@ module.exports = {
     // deal. But I turned it off because loading the plugin causes some obscure
     // syntax error and it didn't seem worth investigating.
     'max-len': OFF,
-    // Prettier forces semicolons in a few places
-    'flowtype/object-type-delimiter': OFF,
 
     // React & JSX
     // Our transforms set this automatically
@@ -166,7 +350,7 @@ module.exports = {
       // We apply these settings to the source files that get compiled.
       // They can use all features including JSX (but shouldn't use `var`).
       files: esNextPaths,
-      parser: 'babel-eslint',
+      parser: 'hermes-eslint',
       parserOptions: {
         ecmaVersion: 8,
         sourceType: 'module',
@@ -204,14 +388,6 @@ module.exports = {
           ERROR,
           {isProductionUserAppCode: false},
         ],
-
-        // Disable accessibility checks
-        'jsx-a11y/aria-role': OFF,
-        'jsx-a11y/no-noninteractive-element-interactions': OFF,
-        'jsx-a11y/no-static-element-interactions': OFF,
-        'jsx-a11y/role-has-required-aria-props': OFF,
-        'jsx-a11y/no-noninteractive-tabindex': OFF,
-        'jsx-a11y/tabindex-no-positive': OFF,
       },
     },
     {
@@ -253,10 +429,69 @@ module.exports = {
     },
   ],
 
+  env: {
+    browser: true,
+    es6: true,
+    node: true,
+    jest: true,
+    jasmine: true,
+  },
+
   globals: {
+    $Call: 'readonly',
+    $ElementType: 'readonly',
+    $Flow$ModuleRef: 'readonly',
+    $FlowFixMe: 'readonly',
+    $Keys: 'readonly',
+    $NonMaybeType: 'readonly',
+    $PropertyType: 'readonly',
+    $ReadOnly: 'readonly',
+    $ReadOnlyArray: 'readonly',
+    $Shape: 'readonly',
+    AnimationFrameID: 'readonly',
+    Class: 'readonly',
+    ClientRect: 'readonly',
+    CopyInspectedElementPath: 'readonly',
+    DOMHighResTimeStamp: 'readonly',
+    EventListener: 'readonly',
+    Iterable: 'readonly',
+    Iterator: 'readonly',
+    JSONValue: 'readonly',
+    JSResourceReference: 'readonly',
+    MouseEventHandler: 'readonly',
+    PropagationPhases: 'readonly',
+    PropertyDescriptor: 'readonly',
+    React$AbstractComponent: 'readonly',
+    React$Component: 'readonly',
+    React$ComponentType: 'readonly',
+    React$Config: 'readonly',
+    React$Context: 'readonly',
+    React$Element: 'readonly',
+    React$ElementConfig: 'readonly',
+    React$ElementProps: 'readonly',
+    React$ElementRef: 'readonly',
+    React$ElementType: 'readonly',
+    React$Key: 'readonly',
+    React$Node: 'readonly',
+    React$Portal: 'readonly',
+    React$Ref: 'readonly',
+    React$StatelessFunctionalComponent: 'readonly',
+    ReadableStreamController: 'readonly',
+    RequestInfo: 'readonly',
+    RequestOptions: 'readonly',
+    ResponseState: 'readonly',
+    StoreAsGlobal: 'readonly',
+    symbol: 'readonly',
+    SyntheticEvent: 'readonly',
+    SyntheticMouseEvent: 'readonly',
+    Thenable: 'readonly',
+    TimeoutID: 'readonly',
+    WheelEventHandler: 'readonly',
+
     spyOnDev: 'readonly',
     spyOnDevAndProd: 'readonly',
     spyOnProd: 'readonly',
+    __DEV__: 'readonly',
     __EXPERIMENTAL__: 'readonly',
     __EXTENSION__: 'readonly',
     __PROFILE__: 'readonly',

diff --git a/package.json b/package.json
@@ -4,10 +4,10 @@
     "packages/*"
   ],
   "devDependencies": {
+    "@actuallyworks/node-fetch": "^2.6.0",
     "@babel/cli": "^7.10.5",
     "@babel/code-frame": "^7.10.4",
     "@babel/core": "^7.11.1",
-    "@babel/eslint-parser": "^7.11.4",
     "@babel/helper-module-imports": "^7.10.4",
     "@babel/parser": "^7.11.3",
     "@babel/plugin-external-helpers": "^7.10.4",
@@ -38,7 +38,6 @@
     "@babel/traverse": "^7.11.0",
     "abort-controller": "^3.0.0",
     "art": "0.10.1",
-    "babel-eslint": "^10.0.3",
     "babel-plugin-syntax-trailing-function-commas": "^6.5.0",
     "chalk": "^3.0.0",
     "cli-table": "^0.3.1",
@@ -50,13 +49,12 @@
     "danger": "^9.2.10",
     "error-stack-parser": "^2.0.6",
     "eslint": "^7.7.0",
-    "eslint-config-fbjs": "^3.1.1",
     "eslint-config-prettier": "^6.9.0",
     "eslint-plugin-babel": "^5.3.0",
     "eslint-plugin-eslint-plugin": "^3.5.3",
     "eslint-plugin-flowtype": "^2.25.0",
+    "eslint-plugin-ft-flow": "^2.0.3",
     "eslint-plugin-jest": "^22.15.0",
-    "eslint-plugin-jsx-a11y": "^6.3.1",
     "eslint-plugin-no-for-of-loops": "^1.0.0",
     "eslint-plugin-no-function-declare-after-return": "^1.0.0",
     "eslint-plugin-react": "^6.7.1",
@@ -68,6 +66,7 @@
     "glob-stream": "^6.1.0",
     "google-closure-compiler": "^20200517.0.0",
     "gzip-size": "^5.1.1",
+    "hermes-eslint": "^0.9.0",
     "jasmine-check": "^1.0.0-rc.0",
     "jest": "^26.6.3",
     "jest-cli": "^26.6.3",
@@ -77,7 +76,6 @@
     "minimist": "^1.2.3",
     "mkdirp": "^0.5.1",
     "ncp": "^2.0.0",
-    "@actuallyworks/node-fetch": "^2.6.0",
     "pacote": "^10.3.0",
     "prettier": "1.19.1",
     "prop-types": "^15.6.2",

diff --git a/packages/eslint-plugin-react-hooks/package.json b/packages/eslint-plugin-react-hooks/package.json
@@ -31,9 +31,11 @@
     "eslint": "^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.11.4",
     "@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
     "@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
     "@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
-    "@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.0.0-0"
+    "@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.0.0-0",
+    "babel-eslint": "^10.0.3"
   }
 }