Pass the destination to startWriting instead of renderToNode

facebook · Oct 6, 2021 · 21db19f · 21db19f
1 parent 844067c
commit 21db19f
Show file tree

Hide file tree

Showing 8 changed files with 80 additions and 121 deletions.
diff --git a/fixtures/flight/server/handler.server.js b/fixtures/flight/server/handler.server.js
@@ -22,10 +22,9 @@ module.exports = function(req, res) {
         const moduleMap = JSON.parse(data);
         const {startWriting} = renderToNodePipe(
           React.createElement(App),
-          res,
           moduleMap
         );
-        startWriting();
+        startWriting(res);
       }
     );
   });

diff --git a/fixtures/ssr/server/render.js b/fixtures/ssr/server/render.js
@@ -20,12 +20,12 @@ export default function render(url, res) {
     console.error('Fatal', error);
   });
   let didError = false;
-  const {startWriting, abort} = renderToNodePipe(<App assets={assets} />, res, {
+  const {startWriting, abort} = renderToNodePipe(<App assets={assets} />, {
     onCompleteShell() {
       // If something errored before we started streaming, we set the error code appropriately.
       res.statusCode = didError ? 500 : 200;
       res.setHeader('Content-type', 'text/html');
-      startWriting();
+      startWriting(res);
     },
     onError(x) {
       didError = true;

diff --git a/fixtures/ssr2/server/render.js b/fixtures/ssr2/server/render.js
@@ -41,13 +41,12 @@ module.exports = function render(url, res) {
     <DataProvider data={data}>
       <App assets={assets} />
     </DataProvider>,
-    res,
     {
       onCompleteShell() {
         // If something errored before we started streaming, we set the error code appropriately.
         res.statusCode = didError ? 500 : 200;
         res.setHeader('Content-type', 'text/html');
-        startWriting();
+        startWriting(res);
       },
       onError(x) {
         didError = true;