Drop Haste (#11303)

* Use relative paths in packages/react

* Use relative paths in packages/react-art

* Use relative paths in packages/react-cs

* Use relative paths in other packages

* Fix as many issues as I can

This uncovered an interesting problem where ./b from package/src/a would resolve to a different instantiation of package/src/b in Jest.

Either this is a showstopper or we can solve it by completely fobbidding remaining /src/.

* Fix all tests

It seems we can't use relative requires in tests anymore. Otherwise Jest becomes confused between real file and symlink.
jestjs/jest#3830

This seems bad... Except that we already *don't* want people to create tests that import individual source files.
All existing cases of us doing so are actually TODOs waiting to be fixed.

So perhaps this requirement isn't too bad because it makes bad code looks bad.

Of course, if we go with this, we'll have to lint against relative requires in tests.
It also makes moving things more painful.

* Prettier

* Remove @providesModule

* Fix remaining Haste imports I missed earlier

* Fix up paths to reflect new flat structure

* Fix Flow

* Fix CJS and UMD builds

* Fix FB bundles

* Fix RN bundles

* Prettier

* Fix lint

* Fix warning printing and error codes

* Fix buggy return

* Fix lint and Flow

* Use Yarn on CI

* Unbreak Jest

* Fix lint

* Fix aliased originals getting included in DEV

Shouldn't affect correctness (they were ignored) but fixes DEV size regression.

* Record sizes

* Fix weird version in package.json

* Tweak bundle labels

* Get rid of output option by introducing react-dom/server.node

* Reconciler should depend on prop-types

* Update sizes last time

package.json

@@ -116,7 +116,7 @@
       ".*": "./scripts/jest/preprocessor.js"
     },
     "transformIgnorePatterns": [
-      "/node_modules/(?!react)"
+      "/node_modules/(?!react|shared|events)"
     ],
     "setupFiles": [
       "./scripts/jest/setup.js",

packages/events/EventPluginHub.js

@@ -3,18 +3,16 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule EventPluginHub
  */
 
 'use strict';
 
-var EventPluginRegistry = require('EventPluginRegistry');
-var EventPluginUtils = require('EventPluginUtils');
-var ReactErrorUtils = require('ReactErrorUtils');
+var EventPluginRegistry = require('./EventPluginRegistry');
+var EventPluginUtils = require('./EventPluginUtils');
+var ReactErrorUtils = require('shared/ReactErrorUtils');
 
-var accumulateInto = require('accumulateInto');
-var forEachAccumulated = require('forEachAccumulated');
+var accumulateInto = require('./accumulateInto');
+var forEachAccumulated = require('./forEachAccumulated');
 var invariant = require('fbjs/lib/invariant');
 
 /**

packages/events/EventPluginRegistry.js

@@ -4,15 +4,18 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule EventPluginRegistry
  * @flow
  */
 
 'use strict';
 
-import type {DispatchConfig} from 'ReactSyntheticEventType';
+import type {DispatchConfig} from './ReactSyntheticEventType';
 
-import type {AnyNativeEvent, PluginName, PluginModule} from 'PluginModuleType';
+import type {
+  AnyNativeEvent,
+  PluginName,
+  PluginModule,
+} from './PluginModuleType';
 
 type NamesToPlugins = {[key: PluginName]: PluginModule<AnyNativeEvent>};
 

packages/events/EventPluginUtils.js

@@ -3,13 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule EventPluginUtils
  */
 
 'use strict';
 
-var ReactErrorUtils = require('ReactErrorUtils');
+var ReactErrorUtils = require('shared/ReactErrorUtils');
 
 var invariant = require('fbjs/lib/invariant');
 

packages/events/EventPropagators.js

@@ -3,17 +3,15 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule EventPropagators
  */
 
 'use strict';
 
-var EventPluginHub = require('EventPluginHub');
-var ReactTreeTraversal = require('ReactTreeTraversal');
+var EventPluginHub = require('./EventPluginHub');
+var ReactTreeTraversal = require('shared/ReactTreeTraversal');
 
-var accumulateInto = require('accumulateInto');
-var forEachAccumulated = require('forEachAccumulated');
+var accumulateInto = require('./accumulateInto');
+var forEachAccumulated = require('./forEachAccumulated');
 
 type PropagationPhases = 'bubbled' | 'captured';
 

packages/events/PluginModuleType.js

@@ -4,17 +4,16 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule PluginModuleType
  * @flow
  */
 
 'use strict';
 
-import type {Fiber} from 'ReactFiber';
+import type {Fiber} from 'react-reconciler/src/ReactFiber';
 import type {
   DispatchConfig,
   ReactSyntheticEvent,
-} from 'ReactSyntheticEventType';
+} from './ReactSyntheticEventType';
 
 export type EventTypes = {[key: string]: DispatchConfig};
 

packages/events/ReactControlledComponent.js

@@ -3,13 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule ReactControlledComponent
  */
 
 'use strict';
 
-var EventPluginUtils = require('EventPluginUtils');
+var EventPluginUtils = require('./EventPluginUtils');
 
 var invariant = require('fbjs/lib/invariant');
 

packages/events/ReactEventEmitterMixin.js

@@ -3,13 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule ReactEventEmitterMixin
  */
 
 'use strict';
 
-var EventPluginHub = require('EventPluginHub');
+var EventPluginHub = require('./EventPluginHub');
 
 function runEventQueueInBatch(events) {
   EventPluginHub.enqueueEvents(events);

packages/events/ReactGenericBatching.js

@@ -3,13 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule ReactGenericBatching
  */
 
 'use strict';
 
-var ReactControlledComponent = require('ReactControlledComponent');
+var ReactControlledComponent = require('./ReactControlledComponent');
 
 // Used as a way to call batchedUpdates when we don't have a reference to
 // the renderer. Such as when we're dispatching events or if third party

packages/events/ReactSyntheticEventType.js

@@ -5,14 +5,12 @@
  * LICENSE file in the root directory of this source tree.
  *
  * Flow type for SyntheticEvent class that includes private properties
- *
- * @providesModule ReactSyntheticEventType
  * @flow
  */
 
 'use strict';
 
-import type {Fiber} from 'ReactFiber';
+import type {Fiber} from 'react-reconciler/src/ReactFiber';
 
 export type DispatchConfig = {
   dependencies: Array<string>,

packages/events/ResponderEventPlugin.js

@@ -3,19 +3,17 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule ResponderEventPlugin
  */
 
 'use strict';
 
-var EventPluginUtils = require('EventPluginUtils');
-var EventPropagators = require('EventPropagators');
-var ReactTreeTraversal = require('ReactTreeTraversal');
-var ResponderSyntheticEvent = require('ResponderSyntheticEvent');
-var ResponderTouchHistoryStore = require('ResponderTouchHistoryStore');
+var EventPluginUtils = require('./EventPluginUtils');
+var EventPropagators = require('./EventPropagators');
+var ReactTreeTraversal = require('shared/ReactTreeTraversal');
+var ResponderSyntheticEvent = require('./ResponderSyntheticEvent');
+var ResponderTouchHistoryStore = require('./ResponderTouchHistoryStore');
 
-var accumulate = require('accumulate');
+var accumulate = require('./accumulate');
 
 var isStartish = EventPluginUtils.isStartish;
 var isMoveish = EventPluginUtils.isMoveish;

packages/events/ResponderSyntheticEvent.js

@@ -3,13 +3,11 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule ResponderSyntheticEvent
  */
 
 'use strict';
 
-var SyntheticEvent = require('SyntheticEvent');
+var SyntheticEvent = require('./SyntheticEvent');
 
 /**
  * `touchHistory` isn't actually on the native event, but putting it in the

packages/events/ResponderTouchHistoryStore.js

@@ -4,13 +4,12 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule ResponderTouchHistoryStore
  * @flow
  */
 
 'use strict';
 
-const EventPluginUtils = require('EventPluginUtils');
+const EventPluginUtils = require('./EventPluginUtils');
 
 const invariant = require('fbjs/lib/invariant');
 

packages/events/SyntheticEvent.js

@@ -3,8 +3,6 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule SyntheticEvent
  */
 
 /* eslint valid-typeof: 0 */

packages/events/__tests__/EventPluginRegistry-test.js

@@ -16,7 +16,7 @@ describe('EventPluginRegistry', () => {
   beforeEach(() => {
     jest.resetModuleRegistry();
     // TODO: can we express this test with only public API?
-    EventPluginRegistry = require('EventPluginRegistry');
+    EventPluginRegistry = require('events/EventPluginRegistry');
 
     createPlugin = function(properties) {
       return Object.assign({extractEvents: function() {}}, properties);

packages/events/__tests__/ResponderEventPlugin-test.js

@@ -9,7 +9,7 @@
 
 'use strict';
 
-var {HostComponent} = require('ReactTypeOfWork');
+var {HostComponent} = require('shared/ReactTypeOfWork');
 
 var EventPluginHub;
 var ResponderEventPlugin;

packages/events/__tests__/accumulateInto-test.js

@@ -13,7 +13,7 @@ var accumulateInto;
 
 describe('accumulateInto', () => {
   beforeEach(() => {
-    accumulateInto = require('accumulateInto');
+    accumulateInto = require('events/accumulateInto');
   });
 
   it('throws if the second item is null', () => {

packages/events/accumulate.js

@@ -4,7 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule accumulate
  * @flow
  */
 

packages/events/accumulateInto.js

@@ -4,7 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule accumulateInto
  * @flow
  */
 

packages/events/forEachAccumulated.js

@@ -4,7 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule forEachAccumulated
  * @flow
  */
 

packages/events/package.json

@@ -0,0 +1,5 @@
+{
+  "private": true,
+  "name": "events",
+  "version": "0.0.0"
+}

packages/react-art/npm/Circle.js

@@ -3,8 +3,6 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule Circle.art
  * @typechecks
  *
  * Example usage:

packages/react-art/npm/Rectangle.js

@@ -3,8 +3,6 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule Rectangle.art
  * @typechecks
  *
  * Example usage:

packages/react-art/npm/Wedge.js

@@ -3,8 +3,6 @@
  *
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
- *
- * @providesModule Wedge.art
  * @typechecks
  *
  * Example usage:

packages/react-art/package.json

@@ -26,6 +26,7 @@
     "prop-types": "^15.6.0"
   },
   "peerDependencies": {
+    "art": "^0.10.1",
     "react": "^16.0.0"
   },
   "files": [

packages/react-art/src/ReactART.js

@@ -18,7 +18,7 @@ const invariant = require('fbjs/lib/invariant');
 const emptyObject = require('fbjs/lib/emptyObject');
 const React = require('react');
 const ReactFiberReconciler = require('react-reconciler');
-const ReactDOMFrameScheduling = require('ReactDOMFrameScheduling');
+const ReactDOMFrameScheduling = require('shared/ReactDOMFrameScheduling');
 
 const {Component} = React;
 

packages/react-cs-renderer/package.json

@@ -5,6 +5,10 @@
   "repository": "facebook/react",
   "dependencies": {
     "fbjs": "^0.8.16",
-    "object-assign": "^4.1.1"
+    "object-assign": "^4.1.1",
+    "prop-types": "^15.6.0"
+  },
+  "peerDependencies": {
+    "react": "^16.0.0"
   }
 }

packages/react-cs-renderer/src/ReactNativeCS.js

@@ -9,12 +9,15 @@
 
 'use strict';
 
-const ReactGenericBatching = require('ReactGenericBatching');
-const ReactVersion = require('ReactVersion');
+const ReactGenericBatching = require('events/ReactGenericBatching');
+const ReactVersion = require('shared/ReactVersion');
 
-const {injectInternals} = require('ReactFiberDevToolsHook');
+// TODO: direct imports like some-package/src/* are bad. Fix me.
+const {
+  injectInternals,
+} = require('react-reconciler/src/ReactFiberDevToolsHook');
 
-import type {ReactNativeCSType} from 'ReactNativeCSTypes';
+import type {ReactNativeCSType} from './ReactNativeCSTypes';
 
 const ReactFiberReconciler = require('react-reconciler');
 

packages/react-cs-renderer/src/ReactNativeCSFeatureFlags.js

@@ -4,13 +4,12 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule ReactNativeCSFeatureFlags
  * @flow
  */
 
 'use strict';
 
-import type {FeatureFlags} from 'ReactFeatureFlags';
+import type {FeatureFlags} from 'shared/ReactFeatureFlags';
 
 var ReactNativeCSFeatureFlags: FeatureFlags = {
   enableAsyncSubtreeAPI: true,

packages/react-cs-renderer/src/ReactNativeCSTypes.js

@@ -4,7 +4,6 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @providesModule ReactNativeCSTypes
  * @flow
  */
 'use strict';