Skip to content

Commit

Permalink
[Flight] Support Blobs from Server to Client (#28755)
Browse files Browse the repository at this point in the history
We currently support Blobs when passing from Client to Server so this
adds it in the other direction for parity - when `enableFlightBinary` is
enabled.

We intentionally only support the `Blob` type to pass-through, not
subtype `File`. That's because passing additional meta data like
filename might be an accidental leak. You can still pass a `File`
through but it'll appear as a `Blob` on the other side. It's also not
possible to create a faithful File subclass in all environments without
it actually being backed by a file.

This implementation isn't great but at least it works. It creates a few
indirections. This is because we need to be able to asynchronously emit
the buffers but we have to "block" the parent object from resolving
while it's loading.

Ideally, we should be able to create the Blob on the client early and
then stream in it lazily. Because the Blob API doesn't guarantee that
the data is available synchronously. Unfortunately, the native APIs
doesn't have this. We could implement custom versions of all the data
read APIs but then the blobs still wouldn't work with native APIs. So we
just have to wait until Blob accepts a stream in the constructor.

We should be able to stream each chunk early in the protocol though even
though we can't unblock the parent until they've all loaded. I didn't do
this yet mostly because of code structure and I'm lazy.

DiffTrain build for [cbb6f2b](cbb6f2b)
  • Loading branch information
sebmarkbage committed Apr 5, 2024
1 parent 75004cd commit 1d8cde0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
f33a6b69c6cb406ea0cc51d07bc4d3fd2d8d8744
cbb6f2b5461cdce282c7e47b9c68a0897d393383
8 changes: 6 additions & 2 deletions compiled/facebook-www/ReactFlightDOMClient-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,10 @@ if (__DEV__) {
return new Set(_data);
}

case "B": {
return undefined;
}

case "I": {
// $Infinity
return Infinity;
Expand Down Expand Up @@ -887,9 +891,9 @@ if (__DEV__) {

default: {
// We assume that anything else is a reference ID.
var _id6 = parseInt(value.slice(1), 16);
var _id7 = parseInt(value.slice(1), 16);

var _chunk2 = getChunk(response, _id6);
var _chunk2 = getChunk(response, _id7);

switch (_chunk2.status) {
case RESOLVED_MODEL:
Expand Down
2 changes: 2 additions & 0 deletions compiled/facebook-www/ReactFlightDOMClient-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,8 @@ function parseModelString(response, parentObject, key, value) {
(response = getOutlinedModel(response, parentObject)),
new Set(response)
);
case "B":
return;
case "I":
return Infinity;
case "-":
Expand Down

0 comments on commit 1d8cde0

Please sign in to comment.