Reconciler: Change commitUpdate signature to account for unused `up…

…datePayload` parameter (#28909) DiffTrain build for commit 82d8129.
facebook · Apr 25, 2024 · 0153ccc · 0153ccc
1 parent f8d55e9
commit 0153ccc
Show file tree

Hide file tree

Showing 7 changed files with 61 additions and 71 deletions.
diff --git a/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js b/...ook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<bb318884da183acc9563b8991ac1663b>>
+ * @generated SignedSource<<c3ec935f7569a8a6d52e0966b2837ffe>>
  */
 
 'use strict';
@@ -2323,7 +2323,7 @@ function shouldAttemptEagerTransition() {
 var scheduleTimeout = setTimeout;
 var cancelTimeout = clearTimeout;
 var noTimeout = -1; // -------------------
-function commitUpdate(instance, updatePayload, type, oldProps, newProps, internalInstanceHandle) {
+function commitUpdate(instance, type, oldProps, newProps, internalInstanceHandle) {
   instance.type = type;
   instance.props = newProps;
 }
@@ -17760,13 +17760,10 @@ function commitMutationEffectsOnFiber(finishedWork, root, lanes) {
               // this case.
 
               var oldProps = current !== null ? current.memoizedProps : newProps;
-              var type = finishedWork.type; // TODO: Type the updateQueue to be specific to host components.
-
-              var _updatePayload = finishedWork.updateQueue;
-              finishedWork.updateQueue = null;
+              var type = finishedWork.type;
 
               try {
-                commitUpdate(_instance2, _updatePayload, type, oldProps, newProps, finishedWork);
+                commitUpdate(_instance2, type, oldProps, newProps, finishedWork);
               } catch (error) {
                 captureCommitPhaseError(finishedWork, finishedWork.return, error);
               }
@@ -22981,7 +22978,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
   return root;
 }
 
-var ReactVersion = '19.0.0-canary-03549b3a';
+var ReactVersion = '19.0.0-canary-6e32de0b';
 
 /*
  * The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

diff --git a/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js b/...ok-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<bbd5884892e3e7b30fece4b277837a1e>>
+ * @generated SignedSource<<20cadeef827c3ff3286e46c141479566>>
  */
 
 "use strict";
@@ -6595,7 +6595,6 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
       if (flags & 4 && ((flags = finishedWork.stateNode), null != flags)) {
         existingHiddenCallbacks = finishedWork.memoizedProps;
         var type = finishedWork.type;
-        finishedWork.updateQueue = null;
         try {
           (flags.type = type), (flags.props = existingHiddenCallbacks);
         } catch (error$102) {
@@ -9146,19 +9145,19 @@ function wrapFiber(fiber) {
     fiberToWrapper.set(fiber, wrapper));
   return wrapper;
 }
-var devToolsConfig$jscomp$inline_1028 = {
+var devToolsConfig$jscomp$inline_1027 = {
   findFiberByHostInstance: function () {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "19.0.0-canary-23c765d3",
+  version: "19.0.0-canary-bf8434d4",
   rendererPackageName: "react-test-renderer"
 };
-var internals$jscomp$inline_1247 = {
-  bundleType: devToolsConfig$jscomp$inline_1028.bundleType,
-  version: devToolsConfig$jscomp$inline_1028.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1028.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1028.rendererConfig,
+var internals$jscomp$inline_1246 = {
+  bundleType: devToolsConfig$jscomp$inline_1027.bundleType,
+  version: devToolsConfig$jscomp$inline_1027.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1027.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1027.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9175,26 +9174,26 @@ var internals$jscomp$inline_1247 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1028.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1027.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-23c765d3"
+  reconcilerVersion: "19.0.0-canary-bf8434d4"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1248 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1247 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1248.isDisabled &&
-    hook$jscomp$inline_1248.supportsFiber
+    !hook$jscomp$inline_1247.isDisabled &&
+    hook$jscomp$inline_1247.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1248.inject(
-        internals$jscomp$inline_1247
+      (rendererID = hook$jscomp$inline_1247.inject(
+        internals$jscomp$inline_1246
       )),
-        (injectedHook = hook$jscomp$inline_1248);
+        (injectedHook = hook$jscomp$inline_1247);
     } catch (err) {}
 }
 exports._Scheduler = Scheduler;

diff --git a/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/...source/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<cda6f05cc9137320b9b41d8810504f84>>
+ * @generated SignedSource<<7e2a599e341d8b9878a6db74c4348769>>
  */
 
 "use strict";
@@ -7026,7 +7026,6 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
       if (flags & 4 && ((flags = finishedWork.stateNode), null != flags)) {
         existingHiddenCallbacks = finishedWork.memoizedProps;
         var type = finishedWork.type;
-        finishedWork.updateQueue = null;
         try {
           (flags.type = type), (flags.props = existingHiddenCallbacks);
         } catch (error$115) {
@@ -9762,12 +9761,12 @@ function wrapFiber(fiber) {
     fiberToWrapper.set(fiber, wrapper));
   return wrapper;
 }
-var devToolsConfig$jscomp$inline_1110 = {
+var devToolsConfig$jscomp$inline_1109 = {
   findFiberByHostInstance: function () {
     throw Error("TestRenderer does not support findFiberByHostInstance()");
   },
   bundleType: 0,
-  version: "19.0.0-canary-a8cb0ecc",
+  version: "19.0.0-canary-b8ced2d7",
   rendererPackageName: "react-test-renderer"
 };
 (function (internals) {
@@ -9784,10 +9783,10 @@ var devToolsConfig$jscomp$inline_1110 = {
   } catch (err) {}
   return hook.checkDCE ? !0 : !1;
 })({
-  bundleType: devToolsConfig$jscomp$inline_1110.bundleType,
-  version: devToolsConfig$jscomp$inline_1110.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1110.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1110.rendererConfig,
+  bundleType: devToolsConfig$jscomp$inline_1109.bundleType,
+  version: devToolsConfig$jscomp$inline_1109.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1109.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1109.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9804,14 +9803,14 @@ var devToolsConfig$jscomp$inline_1110 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1110.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1109.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-a8cb0ecc"
+  reconcilerVersion: "19.0.0-canary-b8ced2d7"
 });
 exports._Scheduler = Scheduler;
 exports.act = act;

diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-d285b3acbade77f9b17e6171dbda69ff4a033878
+82d8129e585cccff30cc0f5fe1bbee6082dd36a5
diff --git a/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<cb882aa4fe69a9a336a3204fe1875ad1>>
+ * @generated SignedSource<<ee4321bdef77b565a51cfdfedf47ac9b>>
  */
 
 'use strict';
@@ -5168,7 +5168,7 @@ function commitTextUpdate(textInstance, oldText, newText) {
 }
 function commitMount(instance, type, newProps, internalInstanceHandle) {// Noop
 }
-function commitUpdate(instance, updatePayloadTODO, type, oldProps, newProps, internalInstanceHandle) {
+function commitUpdate(instance, type, oldProps, newProps, internalInstanceHandle) {
   var viewConfig = instance.viewConfig;
   updateFiberProps(instance._nativeTag, newProps);
   var updatePayload = diff(oldProps, newProps, viewConfig.validAttributes); // Avoid the overhead of bridge calls if there's no update.
@@ -21088,13 +21088,10 @@ function commitMutationEffectsOnFiber(finishedWork, root, lanes) {
               // this case.
 
               var oldProps = current !== null ? current.memoizedProps : newProps;
-              var type = finishedWork.type; // TODO: Type the updateQueue to be specific to host components.
-
-              var _updatePayload = finishedWork.updateQueue;
-              finishedWork.updateQueue = null;
+              var type = finishedWork.type;
 
               try {
-                commitUpdate(_instance2, _updatePayload, type, oldProps, newProps, finishedWork);
+                commitUpdate(_instance2, type, oldProps, newProps, finishedWork);
               } catch (error) {
                 captureCommitPhaseError(finishedWork, finishedWork.return, error);
               }
@@ -26479,7 +26476,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
   return root;
 }
 
-var ReactVersion = '19.0.0-canary-be3bb958';
+var ReactVersion = '19.0.0-canary-a5fea518';
 
 /*
  * The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

diff --git a/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<8912877d0e4069bef75f6199a4eb9f6d>>
+ * @generated SignedSource<<6224a7e892eb62fd99b5ad51269d20b3>>
  */
 
 "use strict";
@@ -8344,7 +8344,6 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
       if (flags & 4 && ((flags = finishedWork.stateNode), null != flags)) {
         var newProps = finishedWork.memoizedProps;
         current = null !== current ? current.memoizedProps : newProps;
-        finishedWork.updateQueue = null;
         try {
           var viewConfig = flags.viewConfig;
           instanceProps.set(flags._nativeTag, newProps);
@@ -10828,10 +10827,10 @@ batchedUpdatesImpl = function (fn, a) {
   }
 };
 var roots = new Map(),
-  devToolsConfig$jscomp$inline_1177 = {
+  devToolsConfig$jscomp$inline_1176 = {
     findFiberByHostInstance: getInstanceFromTag,
     bundleType: 0,
-    version: "19.0.0-canary-b761b2f6",
+    version: "19.0.0-canary-7e594775",
     rendererPackageName: "react-native-renderer",
     rendererConfig: {
       getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10847,11 +10846,11 @@ var roots = new Map(),
       }.bind(null, findNodeHandle)
     }
   };
-var internals$jscomp$inline_1461 = {
-  bundleType: devToolsConfig$jscomp$inline_1177.bundleType,
-  version: devToolsConfig$jscomp$inline_1177.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1177.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1177.rendererConfig,
+var internals$jscomp$inline_1460 = {
+  bundleType: devToolsConfig$jscomp$inline_1176.bundleType,
+  version: devToolsConfig$jscomp$inline_1176.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1176.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1176.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -10867,26 +10866,26 @@ var internals$jscomp$inline_1461 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1177.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1176.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-b761b2f6"
+  reconcilerVersion: "19.0.0-canary-7e594775"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1462 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1461 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1462.isDisabled &&
-    hook$jscomp$inline_1462.supportsFiber
+    !hook$jscomp$inline_1461.isDisabled &&
+    hook$jscomp$inline_1461.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1462.inject(
-        internals$jscomp$inline_1461
+      (rendererID = hook$jscomp$inline_1461.inject(
+        internals$jscomp$inline_1460
       )),
-        (injectedHook = hook$jscomp$inline_1462);
+        (injectedHook = hook$jscomp$inline_1461);
     } catch (err) {}
 }
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {

diff --git a/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<7f692e85122cfe7dc3f7349af67afd3f>>
+ * @generated SignedSource<<ac7520347f9b10440c4fd0a9409e372d>>
  */
 
 "use strict";
@@ -8827,7 +8827,6 @@ function commitMutationEffectsOnFiber(finishedWork, root) {
       if (flags & 4 && ((flags = finishedWork.stateNode), null != flags)) {
         var newProps = finishedWork.memoizedProps;
         current = null !== current ? current.memoizedProps : newProps;
-        finishedWork.updateQueue = null;
         try {
           var viewConfig = flags.viewConfig;
           instanceProps.set(flags._nativeTag, newProps);
@@ -11534,10 +11533,10 @@ batchedUpdatesImpl = function (fn, a) {
   }
 };
 var roots = new Map(),
-  devToolsConfig$jscomp$inline_1257 = {
+  devToolsConfig$jscomp$inline_1256 = {
     findFiberByHostInstance: getInstanceFromTag,
     bundleType: 0,
-    version: "19.0.0-canary-c42c3217",
+    version: "19.0.0-canary-8d977274",
     rendererPackageName: "react-native-renderer",
     rendererConfig: {
       getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11567,10 +11566,10 @@ var roots = new Map(),
   } catch (err) {}
   return hook.checkDCE ? !0 : !1;
 })({
-  bundleType: devToolsConfig$jscomp$inline_1257.bundleType,
-  version: devToolsConfig$jscomp$inline_1257.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1257.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1257.rendererConfig,
+  bundleType: devToolsConfig$jscomp$inline_1256.bundleType,
+  version: devToolsConfig$jscomp$inline_1256.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1256.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1256.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -11586,14 +11585,14 @@ var roots = new Map(),
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1257.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1256.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "19.0.0-canary-c42c3217"
+  reconcilerVersion: "19.0.0-canary-8d977274"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
   computeComponentStackForErrorReporting: function (reactTag) {
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		d285b3acbade77f9b17e6171dbda69ff4a033878
		82d8129e585cccff30cc0f5fe1bbee6082dd36a5