Added documentation for additional fields of Image #9304
Conversation
|
By analyzing the blame information on this pull request, we identified @davidaurelio and @JoelMarcey to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
docs/Images.md
Outdated
| @@ -91,6 +91,22 @@ Many of the images you will display in your app will not be available at compile | |||
| <Image source={{uri: 'https://facebook.github.io/react/img/logo_og.png'}} /> | |||
| ``` | |||
|
|
|||
| ### Network Requests for Images | |||
|
|
|||
| If you would like to set things as HTTP-Verb, Headers or a Body along with the image request you may do this by defining these properties on the source object: | |||
|
Thanks. Just a couple of comments. Then we can ship. |
|
thanks @DanielMSchmidt please bear in mind, the android counterpart of that commit has not been merged yet, 7791, so current documentation should at least mention this? or maybe it is better to hold it until it has been merged |
ghost
added
the
CLA Signed
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context? |
ghost
added
the
CLA Signed
|
I think we may still be waiting for #7791 to be merged here -- is that right @ospfranco? |
|
The small changes I requested can be made in the meantime. |
ghost
added
the
CLA Signed
|
Thanks for the review @JoelMarcey 👍 |
ghost
added
the
CLA Signed
DanielMSchmidt
force-pushed
the
patch-3
branch
from
df1157e
to
d68b242
Compare
|
I just updated the PR to deal with your comments @joelcloralt |
|
@DanielMSchmidt updated the pull request - view changes |
|
Thanks. SO now we just need to decide whether this needs to wait for #7791 |
ghost
added
the
CLA Signed
|
It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @davidaurelio as a potential reviewer. Could you take a look please or cc someone with more context? |
facebook-github-bot
added
the
CLA Signed
|
#7791 is still open. We are still waiting for that, right? |
|
Hey @JoelMarcey, sorry I was short on time, yes #7791 is still open: it was dependent on a change @rigdern made on Fresco framework for android, now that is merged so we are waiting on the pull request to be merged to react-native, once that is merged you can push this too. |
facebook-github-bot
added
the
CLA Signed
|
Waiting on #7791 ... |
|
Still waiting on this functionality actually getting in. |
|
Waiting... |
facebook-github-bot
added
the
Import Started
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Could you rebase this change? |
Add method, headers and body example for Image component
|
@javache Did so 👍 |
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Hi there, As ospfranco found there is some documentation for the code coming from facebook#7338 missing, so I added it. It concerns the method, headers and bdoy field on the Image source object. If you would like to have any changes made, please don't hesitate to comment, I will add them. Have a nice day and thank you for maintaining React Native! Closes facebook#9304 Differential Revision: D4913262 Pulled By: javache fbshipit-source-id: 922430ec3388560686e1cf53cb5dff7f30e4e31f
Summary: Hi there, As ospfranco found there is some documentation for the code coming from facebook#7338 missing, so I added it. It concerns the method, headers and bdoy field on the Image source object. If you would like to have any changes made, please don't hesitate to comment, I will add them. Have a nice day and thank you for maintaining React Native! Closes facebook#9304 Differential Revision: D4913262 Pulled By: javache fbshipit-source-id: 922430ec3388560686e1cf53cb5dff7f30e4e31f
Hi there,
As @ospfranco found there is some documentation for the code coming from #7338 missing, so I added it. It concerns the method, headers and bdoy field on the Image source object.
If you would like to have any changes made, please don't hesitate to comment, I will add them.
Have a nice day and thank you for maintaining React Native!