[ReactNative|Easy] Change watchman too-long error message #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
It is. Will pull shortly |
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: @wez Mentioned this in Issue #239 -- right now when watchman takes too long we recommend you run `watchman` from your terminal which actually expects some arguments, so it prints out the following: ``` [pcottle:~/Desktop/react-native:changeErrorMessage]$ watchman { "error": "invalid command (expected an array with some elements!)", "cli_validated": true, "version": "3.0.0" } ``` basically this ends up being more confusing since the command we recommend you run errors out, so lets change it to `watchman version` which at least exists cleanly. I kept the troubleshooting link as https://facebook.github.io/watchman/docs/troubleshooting.html since it sounds like we will update that with the issue people run into in #239 Closes facebook/react-native#825 Github Author: Peter Cottle <[email protected]> Test Plan: Imported from GitHub, without a `Test Plan:` line.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 12, 2018
Summary: `YGRoundValueToPixelGrid` currently rounds negative numbers incorrectly. For example: ``` YGRoundValueToPixelGrid(-2.2, 1.0, /* ceil */ false, /* floor */ true) = -2.0 ``` However, that operation is supposed to take the floor of the number so the result should acutally be `-3.0`. There's a detailed comment in `YGRoundValueToPixelGrid` about the fix and why it works. A symptom that manifested because of this bug is that text nodes could get smaller and smaller on each layout pass. For details see facebook/yoga#824. Fixes #824 Adam Comella Microsoft Corp. Pull Request resolved: facebook/yoga#825 Reviewed By: priteshrnandgaonkar Differential Revision: D10282064 Pulled By: shergin fbshipit-source-id: 16ca966e6cb0cfc88b1dbf4ba31e7b1dbe1f2049
t-nanava
referenced
this pull request
in microsoft/react-native-macos
Jun 17, 2019
Summary: `YGRoundValueToPixelGrid` currently rounds negative numbers incorrectly. For example: ``` YGRoundValueToPixelGrid(-2.2, 1.0, /* ceil */ false, /* floor */ true) = -2.0 ``` However, that operation is supposed to take the floor of the number so the result should acutally be `-3.0`. There's a detailed comment in `YGRoundValueToPixelGrid` about the fix and why it works. A symptom that manifested because of this bug is that text nodes could get smaller and smaller on each layout pass. For details see facebook/yoga#824. Fixes #824 Adam Comella Microsoft Corp. Pull Request resolved: facebook/yoga#825 Reviewed By: priteshrnandgaonkar Differential Revision: D10282064 Pulled By: shergin fbshipit-source-id: 16ca966e6cb0cfc88b1dbf4ba31e7b1dbe1f2049
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
On my machine with Manjaro Linux 18.0.3 bash profile doesn't work, but .bashrc works. Bash version: 5.0.0(1) release uname: Linux marat-pc 4.19.23-1-MANJARO
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Sep 28, 2021
…-2020-07-31 Merge from upstream through 2020-07-31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wez Mentioned this in Issue #239 -- right now when watchman takes too long we recommend you run
watchmanfrom your terminal which actually expects some arguments, so it prints out the following:basically this ends up being more confusing since the command we recommend you run errors out, so lets change it to
watchman versionwhich at least exists cleanly.I kept the troubleshooting link as https://facebook.github.io/watchman/docs/troubleshooting.html since it sounds like we will update that with the issue people run into in #239