Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when installing globally react-native instead of react-native-cli #754

Merged
merged 1 commit into from
Apr 8, 2015

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Apr 8, 2015

This adds a react-native binary that just output some instructions.

screen shot 2015-04-08 at 8 15 41 am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2015
@frantic
Copy link
Contributor

frantic commented Apr 8, 2015

I'd change the language a little bit, maybe "Looks like you installed react-native globally, maybe you meant react-native-cli? To fix the issue, run:"

cc @sahrens

This adds a react-native binary that just output some instructions.
@vjeux vjeux force-pushed the warn_global_cli branch from 99bfef7 to 0a5967d Compare April 8, 2015 18:16
@vjeux
Copy link
Contributor Author

vjeux commented Apr 8, 2015

Updated! Much better wording indeed. I also toned down the red

screen shot 2015-04-08 at 11 16 04 am

vjeux added a commit that referenced this pull request Apr 8, 2015
Warn when installing globally react-native instead of react-native-cli
@vjeux vjeux merged commit d2c00d5 into facebook:master Apr 8, 2015
@vjeux vjeux deleted the warn_global_cli branch April 13, 2015 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants