Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android click sounds on press #6825

Closed
wants to merge 1 commit into from
Closed

Android click sounds on press #6825

wants to merge 1 commit into from

Commits on Jun 19, 2016

  1. Android click sound onPress of Touchable component 

    Android's onClick listener will trigger a sound effect by default when a
user has system sounds enabled. Since React implements it's own click
model, we should manually trigger the sound.

To test:
1. Ensure volume is turned up
2. Settings > Sound & Notification > Other sounds > enable Touch sounds
3. Click any Touchable* React component
4. You should hear a click on press
5. Settings > Sound & Notification > Other sounds > disable Touch sounds
6. Click any Touchable* React component
7. You should not hear a click
    @mikemonteith
    mikemonteith committed Jun 19, 2016
    Configuration menu
    Copy the full SHA
    9007d66 View commit details
    Browse the repository at this point in the history