Updated ExplorerPage to use static title field #5118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statics field was never used, I came with intent to remove it. I changed course when I noticed that this title matched the static.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
| @@ -44,7 +44,7 @@ var ToolbarAndroidExample = React.createClass({ | |||
| }, | |||
| render: function() { | |||
| return ( | |||
| <UIExplorerPage title="<ToolbarAndroid>"> | |||
| <UIExplorerPage title={statics.title}> | |||
|
@kwelch updated the pull request. |
|
First off, thanks for the PR! However, it doesn't really make sense to me why we're updating exactly one example to be like this... I'd probably be ok with updating all of them, but really I don't think it's worth your time doing -- this isn't really much of an issue :) |
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statics field was never used, I came with intent to remove it. I changed course when I noticed that this title matched the static.