FIX: Support inline images in Text with lineHeight #48994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request addresses the image overflow issue in React Native's component when
lineHeight
is specified. By modifying the native code forRCTTextView.mm
, we have:setTextStorage
method to handle images withinNSTextStorage
.drawRect:
method to ensure images are drawn correctly.These changes ensure proper positioning and rendering of images, fixing the long-standing overflow issue.
Changelog:
[IOS] [FIXED] - Resolved image overflow issue in component when
lineHeight
is specified by updatingRCTTextView.mm
.Test Plan:
Example test steps:
lineHeight
values and observe rendering.