Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the enableAccumulatedUpdatesInRawPropsAndroid QE for View only #48852

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmytrorykun
Copy link
Contributor

Summary:
The enableAccumulatedUpdatesInRawPropsAndroid param will be tested together with the enablePropsUpdateReconciliationAndroid param.

enablePropsUpdateReconciliationAndroid currently only supports View components.

This diff changes enableAccumulatedUpdatesInRawPropsAndroid to also run only for Views.

Differential Revision: D68492332

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68492332

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68492332

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 24, 2025
…acebook#48852)

Summary:
Pull Request resolved: facebook#48852

The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param.

`enablePropsUpdateReconciliationAndroid` currently only supports `View` components.

This diff changes `enableAccumulatedUpdatesInRawPropsAndroid`  to also run only for `View`s.

Differential Revision: D68492332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68492332

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 27, 2025
…acebook#48852)

Summary:
Pull Request resolved: facebook#48852

The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param.

`enablePropsUpdateReconciliationAndroid` currently only supports `View` components.

This diff changes `enableAccumulatedUpdatesInRawPropsAndroid`  to also run only for `View`s.

Differential Revision: D68492332
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request Jan 27, 2025
…acebook#48852)

Summary:

The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param.

`enablePropsUpdateReconciliationAndroid` currently only supports `View` components.

This diff changes `enableAccumulatedUpdatesInRawPropsAndroid`  to also run only for `View`s.

Differential Revision: D68492332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68492332

…acebook#48939)

Summary:

The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor.

This diff moves the experimental logic to `ConcreteComponentDescriptor`.

Changelog: [Internal]

Differential Revision: D68633985
…acebook#48852)

Summary:

The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param.

`enablePropsUpdateReconciliationAndroid` currently only supports `View` components.

This diff changes `enableAccumulatedUpdatesInRawPropsAndroid`  to also run only for `View`s.

Differential Revision: D68492332
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68492332

@facebook-github-bot
Copy link
Contributor

Hi @dmytrorykun!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants