-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the enableAccumulatedUpdatesInRawPropsAndroid QE for View only #48852
base: main
Are you sure you want to change the base?
Conversation
This pull request was exported from Phabricator. Differential Revision: D68492332 |
This pull request was exported from Phabricator. Differential Revision: D68492332 |
…acebook#48852) Summary: Pull Request resolved: facebook#48852 The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
c11fe68
to
17eb0cd
Compare
This pull request was exported from Phabricator. Differential Revision: D68492332 |
…acebook#48852) Summary: Pull Request resolved: facebook#48852 The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
17eb0cd
to
6a25fbe
Compare
…acebook#48852) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
6a25fbe
to
9bf7f33
Compare
This pull request was exported from Phabricator. Differential Revision: D68492332 |
…acebook#48939) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor. This diff moves the experimental logic to `ConcreteComponentDescriptor`. Changelog: [Internal] Differential Revision: D68633985
…acebook#48852) Summary: The `enableAccumulatedUpdatesInRawPropsAndroid` param will be tested together with the `enablePropsUpdateReconciliationAndroid` param. `enablePropsUpdateReconciliationAndroid` currently only supports `View` components. This diff changes `enableAccumulatedUpdatesInRawPropsAndroid` to also run only for `View`s. Differential Revision: D68492332
9bf7f33
to
d194c5e
Compare
This pull request was exported from Phabricator. Differential Revision: D68492332 |
Hi @dmytrorykun! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Summary:
The
enableAccumulatedUpdatesInRawPropsAndroid
param will be tested together with theenablePropsUpdateReconciliationAndroid
param.enablePropsUpdateReconciliationAndroid
currently only supportsView
components.This diff changes
enableAccumulatedUpdatesInRawPropsAndroid
to also run only forView
s.Differential Revision: D68492332