Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getConcretePropsShared() #48710

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/react-native/ReactCommon/react/renderer/core/Concrete…
…ShadowNode.h

Co-authored-by: Pieter De Baets <[email protected]>
mrousavy and javache authored Jan 21, 2025
commit 5f25ec4f068d1d27540232ede91bf44bc933e8d9
Original file line number Diff line number Diff line change
@@ -109,7 +109,7 @@ class ConcreteShadowNode : public BaseShadowNodeT {
* Returns a concrete props object associated with the node, as a shared_ptr.
* Thread-safe after the node is sealed.
*/
const std::shared_ptr<ConcreteProps>& getConcretePropsShared() const {
const std::shared_ptr<const ConcreteProps>& getConcretePropsShared() const {
mrousavy marked this conversation as resolved.
Show resolved Hide resolved
react_native_assert(
BaseShadowNodeT::props_ && "Props must not be `nullptr`.");
return std::static_pointer_cast<ConcreteProps>(props_);

Unchanged files with check annotations Beta

// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a key error in LogBox', () => {

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (20)

Disabled test

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (18)

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();
// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a fragment warning in LogBox', () => {

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (20)

Disabled test

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

GitHub Actions / test_js (18)

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();
/* eslint-env jest */
import type {ReactTestRenderer as ReactTestRendererType} from 'react-test-renderer';

Check warning on line 13 in packages/react-native/Libraries/Utilities/ReactNativeTestTools.js

GitHub Actions / test_js (20)

Requires should be sorted alphabetically

Check warning on line 13 in packages/react-native/Libraries/Utilities/ReactNativeTestTools.js

GitHub Actions / test_js (18)

Requires should be sorted alphabetically
import TouchableWithoutFeedback from '../Components/Touchable/TouchableWithoutFeedback';
describe('getRootNode()', () => {
// This is the desired implementation (not implemented yet).
it.skip('returns a root node representing the document', () => {

Check warning on line 257 in packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js

GitHub Actions / test_js (20)

Disabled test

Check warning on line 257 in packages/react-native/src/private/webapis/dom/nodes/__tests__/ReactNativeElement-itest.js

GitHub Actions / test_js (18)

Disabled test
let lastParentANode;
let lastParentBNode;
let lastChildANode;