Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProgressResponseBody test cases #48675

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add ProgressResponseBody test cases #48675

wants to merge 3 commits into from

Conversation

mateoguzmana
Copy link
Contributor

Summary:

The class is still in Java and also lacks of some tests so adding them to make it safer to migrate or for future refactors.

Changelog:

[INTERNAL] - Add ProgressResponseBodyTest test cases

Test Plan:

yarn test-android

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 14, 2025
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

rshest
rshest requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@rshest rshest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are mostly nitpicks, but would appreciate if acted upon, thanks!

...ve/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressResponseBodyTest.kt Outdated Show resolved Hide resolved
...ve/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressResponseBodyTest.kt Outdated Show resolved Hide resolved
...ve/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressResponseBodyTest.kt Outdated Show resolved Hide resolved
...ve/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressResponseBodyTest.kt Outdated Show resolved Hide resolved
...ve/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressResponseBodyTest.kt Outdated Show resolved Hide resolved
@mateoguzmana
Copy link
Contributor Author

Thanks for the feedback @rshest! I've addressed all the comments in d489fed

@mateoguzmana mateoguzmana requested a review from rshest January 15, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshest rshest Awaiting requested review from rshest

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateoguzmana @facebook-github-bot @rshest