RN-Tester: Make the New Architecture sample scrollable #48666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68153245 |
Summary: The New Architecture sample is getting too big and the two views are not visible anymore. I'm fixing this but having buttons side by side. Changelog: [Internal] [Changed] - Differential Revision: D68153245
cortinico
force-pushed
the
export-D68153245
branch
from
72400da to
0f41374
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68153245 |
|
This pull request has been merged in 6368555. |
|
This pull request was successfully merged by @cortinico in 6368555 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The New Architecture sample is getting too big and the two views are not visible anymore.
I'm fixing this but adding a ScrollView.
Changelog:
[Internal] [Changed] - RN-Tester: Make the New Architecture sample scrollable
Differential Revision: D68153245