Migrate Libraries/Utilities/*.js to use export syntax.
#48665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
2 times, most recently
from
7953b2a to
78f526e
Compare
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
78f526e to
aea5e38
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
aea5e38 to
a85982f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 16, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
a85982f to
920bf69
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 16, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
920bf69 to
1bf275f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 24, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
1bf275f to
91383ce
Compare
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 24, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Reviewed By: huntie Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
91383ce to
7d53951
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 24, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Reviewed By: huntie Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
7d53951 to
2cccb8c
Compare
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. - Updates the public API snapshot (intented breaking change) Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Reviewed By: huntie Differential Revision: D68152910
|
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
force-pushed
the
export-D68152910
branch
from
2cccb8c to
2814051
Compare
|
This pull request has been merged in 52ffda7. |
|
This pull request was successfully merged by @iwoplaza in 52ffda7 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling
This diff
exportsyntaxexport defaultfor qualified objects, manyexportstatements for collections (determined by how it's imported).defaultto requires of the changed files.Changelog:
[General][Breaking] - Files inside
Libraries/Utilitiesuseexportsyntax, which requires the addition of.defaultwhen imported with the CJSrequiresyntax.Differential Revision: D68152910