Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Libraries/Utilities/*.js to use export syntax. #48665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iwoplaza
Copy link
Contributor

Summary:

Motivation

Modernising the react-native codebase to allow for ingestion by modern Flow tooling

This diff

  • Updates files in Libraries/Utilities to use export syntax
    • export default for qualified objects, many export statements for collections (determined by how it's imported)
  • Appends .default to requires of the changed files.

Changelog:
[General][Breaking] - Files inside Libraries/Utilities use export syntax, which requires the addition of .default when imported with the CJS require syntax.

Differential Revision: D68152910

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 14, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

iwoplaza added a commit to iwoplaza/react-native that referenced this pull request Jan 14, 2025
)

Summary:
Pull Request resolved: facebook#48665

## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling

## This diff
- Updates files in Libraries/Utilities to use `export` syntax
  - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported)
- Appends `.default` to requires of the changed files.

Changelog:
[General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.

Differential Revision: D68152910
@iwoplaza iwoplaza force-pushed the export-D68152910 branch 2 times, most recently from 7953b2a to 78f526e Compare January 14, 2025 19:34
iwoplaza added a commit to iwoplaza/react-native that referenced this pull request Jan 14, 2025
)

Summary:
Pull Request resolved: facebook#48665

## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling

## This diff
- Updates files in Libraries/Utilities to use `export` syntax
  - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported)
- Appends `.default` to requires of the changed files.
- Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files.

Changelog:
[General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.

Differential Revision: D68152910
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

iwoplaza added a commit to iwoplaza/react-native that referenced this pull request Jan 14, 2025
)

Summary:
Pull Request resolved: facebook#48665

## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling

## This diff
- Updates files in Libraries/Utilities to use `export` syntax
  - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported)
- Appends `.default` to requires of the changed files.
- Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files.

Changelog:
[General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.

Differential Revision: D68152910
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

)

Summary:
Pull Request resolved: facebook#48665

## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling

## This diff
- Updates files in Libraries/Utilities to use `export` syntax
  - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported)
- Appends `.default` to requires of the changed files.
- Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files.

Changelog:
[General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.

Differential Revision: D68152910
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68152910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants