-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Libraries/Utilities/*.js to use export
syntax.
#48665
Open
iwoplaza
wants to merge
1
commit into
facebook:main
Choose a base branch
from
iwoplaza:export-D68152910
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+180
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 14, 2025
This pull request was exported from Phabricator. Differential Revision: D68152910 |
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
2 times, most recently
from
January 14, 2025 19:34
7953b2a
to
78f526e
Compare
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
added a commit
to iwoplaza/react-native
that referenced
this pull request
Jan 14, 2025
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
iwoplaza
force-pushed
the
export-D68152910
branch
from
January 14, 2025 19:48
78f526e
to
aea5e38
Compare
This pull request was exported from Phabricator. Differential Revision: D68152910 |
) Summary: Pull Request resolved: facebook#48665 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling ## This diff - Updates files in Libraries/Utilities to use `export` syntax - `export default` for qualified objects, many `export` statements for collections (determined by how it's imported) - Appends `.default` to requires of the changed files. - Updates Jest mocks of the `Platform` module, which happened to touch a lot of test files. Changelog: [General][Breaking] - Files inside `Libraries/Utilities` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax. Differential Revision: D68152910
This pull request was exported from Phabricator. Differential Revision: D68152910 |
iwoplaza
force-pushed
the
export-D68152910
branch
from
January 14, 2025 20:01
aea5e38
to
a85982f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling
This diff
export
syntaxexport default
for qualified objects, manyexport
statements for collections (determined by how it's imported).default
to requires of the changed files.Changelog:
[General][Breaking] - Files inside
Libraries/Utilities
useexport
syntax, which requires the addition of.default
when imported with the CJSrequire
syntax.Differential Revision: D68152910