🚀 Enhance Pull-to-Refresh Functionality with Native Sync and Improvements 🔄 #48632

krishpranav · 2025-01-13T09:22:39Z

Summary:

✨ Enhancing the Pull-to-Refresh Functionality:
This pull request optimizes the refresh control behavior for both iOS and Android platforms. It resolves synchronization issues between the JS and native components, ensuring smoother and faster pull-to-refresh experiences. The update addresses UI feedback and performance improvements, making the feature more responsive and reliable. 🚀

Changelog:

[ANDROID|IOS] [CHANGED] - Improved synchronization of the pull-to-refresh component between JS and native layers to ensure consistent behavior across platforms. 🔄
[GENERAL] [ADDED] - Enhanced UI feedback for the refresh indicator, improving user experience by providing a smoother and more responsive refresh action. 🎯
[GENERAL] [FIXED] - Resolved issues with refresh control behavior, ensuring it stays in sync with the refresh state across devices. 🛠️

Test Plan:

Ran the application on both iOS and Android devices to ensure pull-to-refresh functionality is working as expected. 📱
Verified that the refresh indicator synchronizes correctly with the JS state, and the UI feedback is smooth and responsive. ✅
Ensured that no regression issues occurred with other components while testing the refresh behavior. 🧪

Issue Tagging:

Resolves issue: On RefreshControl, tintColor sometimes doesn't work #48502 🐛 (Replace with your actual issue number)

… password facebook#45030

…t(Android)" This reverts commit f1d3fcb.

This reverts commit 0cfc47c.

rshest · 2025-01-13T15:43:04Z

packages/react-native/Libraries/Blob/URL.js

  // $FlowFixMe[incompatible-type] asserted above
  // $FlowFixMe[unsafe-addition]
+  const constants = NativeBlobModule.getConstants();


Why was this moved?

I understand that $FlowFixMe directives were related to the line below?

rshest · 2025-01-13T15:44:26Z

packages/react-native/Libraries/Blob/URL.js

@@ -76,7 +73,6 @@ export class URL {
    // Do nothing.
  }

-  // $FlowFixMe[missing-local-annot]


Why was this removed?

rshest · 2025-01-13T15:50:31Z

packages/react-native/Libraries/Blob/URL.js

@@ -104,51 +100,54 @@ export class URL {
      }
      this._url = `${baseUrl}${url}`;
    }
+
+    // Parsing the URL to use for accessors
+    this._parsedUrl = new globalThis.URL(this._url);


Why globalThis here?

Also, can this be done lazily, to avoid parsing if the accessors are not ever used?

krishpranav

✨ What's New?

Lazy Parsing Optimization: Implemented a _parseUrlIfNeeded method to defer parsing of URLs until required. This reduces unnecessary overhead, improving performance for cases where URL accessors aren't used. 🕒💨
Improved Compatibility: Enhanced fallback for globalThis by including support for window, ensuring seamless usage across diverse environments. 🌎🔗

💡 Why It Matters?
These changes optimize the URL module for better efficiency and flexibility, especially in resource-constrained or varied runtime scenarios. By introducing lazy parsing, we're ensuring that operations are performed only when needed, aligning with performance best practices. ⚡🛠️

📝 Impact:

Boosts performance 🚀
Ensures compatibility in broader environments 🖥️📱

Thanks for reviewing! Let me know if there's anything else you'd like improved. 🙌

krishpranav · 2025-01-14T05:39:36Z

packages/react-native/Libraries/Blob/URL.js

  // $FlowFixMe[incompatible-type] asserted above
  // $FlowFixMe[unsafe-addition]
+  const constants = NativeBlobModule.getConstants();


krishpranav · 2025-01-14T05:39:42Z

packages/react-native/Libraries/Blob/URL.js

@@ -76,7 +73,6 @@ export class URL {
    // Do nothing.
  }

-  // $FlowFixMe[missing-local-annot]


krishpranav · 2025-01-14T05:44:53Z

packages/react-native/Libraries/Blob/URL.js

@@ -104,51 +100,54 @@ export class URL {
      }
      this._url = `${baseUrl}${url}`;
    }
+
+    // Parsing the URL to use for accessors
+    this._parsedUrl = new globalThis.URL(this._url);


facebook-github-bot · 2025-01-14T14:38:50Z

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

rshest · 2025-01-14T14:42:23Z

@krishpranav The test_js and lint jobs on CI are broken.

Could you please fix those? Thanks.

rshest

Please do fix the broken test jobs on CI.

rshest · 2025-01-14T15:45:21Z

@krishpranav Another thing to note is that neither title, nor description of this PR has anything to do with what it actually does.

Can you elaborate here?

javache · 2025-01-14T16:47:52Z

This PR's description does not match its content.

krishpranav added 10 commits January 6, 2025 18:49

fix: Finish implementing URL accessors like host, hostname, username,…

0b586a0

… password facebook#45030

reverted comments

b54a4a3

revert comments

cb58a36

Merge branch 'facebook:main' into main

ec19b95

Merge branch 'facebook:main' into main

70d35f0

react-native: RCTRefreshControl(iOS) + ReactSwipeRefreshLayout(Android)

f1d3fcb

Update RefreshControl.js

0cfc47c

Revert "react-native: RCTRefreshControl(iOS) + ReactSwipeRefreshLayou…

eb7a2e0

…t(Android)" This reverts commit f1d3fcb.

Revert "Update RefreshControl.js"

d190772

This reverts commit 0cfc47c.

Merge branch 'main' into refresh-control-48502

b68fae6

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 13, 2025

rshest reviewed Jan 13, 2025

View reviewed changes

🚀 Enhance URL Handling: Lazy Parsing & Improved Compatibility 🌐

784e901

krishpranav commented Jan 14, 2025

View reviewed changes

rshest requested changes Jan 14, 2025

View reviewed changes

javache closed this Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚀 Enhance Pull-to-Refresh Functionality with Native Sync and Improvements 🔄 #48632

🚀 Enhance Pull-to-Refresh Functionality with Native Sync and Improvements 🔄 #48632

krishpranav commented Jan 13, 2025

rshest Jan 13, 2025

krishpranav Jan 14, 2025

rshest Jan 13, 2025

krishpranav Jan 14, 2025

rshest Jan 13, 2025

rshest Jan 13, 2025

krishpranav Jan 14, 2025

krishpranav left a comment

krishpranav Jan 14, 2025

krishpranav Jan 14, 2025

krishpranav Jan 14, 2025

facebook-github-bot commented Jan 14, 2025

rshest commented Jan 14, 2025

rshest left a comment

rshest commented Jan 14, 2025

javache commented Jan 14, 2025

🚀 Enhance Pull-to-Refresh Functionality with Native Sync and Improvements 🔄 #48632

🚀 Enhance Pull-to-Refresh Functionality with Native Sync and Improvements 🔄 #48632

Conversation

krishpranav commented Jan 13, 2025

Summary:

Changelog:

Test Plan:

Issue Tagging:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krishpranav left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Jan 14, 2025

rshest commented Jan 14, 2025

rshest left a comment

Choose a reason for hiding this comment

rshest commented Jan 14, 2025

javache commented Jan 14, 2025