[2/2] Fix RNTester strict mode warnings #48620
Closed
+219
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@mateoguzmana Thanks for looking into this and fixing this examples!
cipolleschi
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
@mateoguzmana Thanks for looking into this and fixing this examples!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in cc4e4c7. |
|
This pull request was successfully merged by @mateoguzmana in cc4e4c7 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up from #48619. While investigating #22186, some false positives showed up as some of the examples also have non-strict mode compatible code.
In this PR: Converting from class to functional components some
AnExAppexamples that were usingUNSAFE_lifecycles.Changelog:
[INTERNAL] - Fix RNTester strict mode warnings for AnExApp examples
Test Plan:
RNTesterAppShared.jswithStrictModeand verified that no warnings are shown anymore for the updated components.