Make TouchableNativeFeedback
strict mode compatible
#48522
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Related to #22186
There are still some components that are not strict mode compatible. I found this one when wrapping the RNTester in
StrictMode
and opening theDrawerLayoutAndroid
example.The
Button
component usesTouchableNativeFeedback
for Android which is currently usingfindHostInstance_DEPRECATED
to manage the ref. In this PR we simply swipe the way of attaching the reference by usingcreateRef
.StrictMode error for TouchableNativeFeedback
Changelog:
[GENERAL] [FIXED] - Make
TouchableNativeFeedback
strict mode compatibleTest Plan:
findHostInstance_DEPRECATED(this)
and verified it still triggers the relatedCommands
calls.