Use proper mockito/kotlin for RootViewTest and JSPointerDispatcherTest #48490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D67793108
Summary: ## Changelog: [Internal] - This makes the `RootViewTest` and `JSPointerDispatcher` tests to use mockito-kotlin instead of the Java Mockito, which is the legacy of the conversion of the corresponding tests from Java. Which: * is the right thing to do, as we have more Kotlin-idiomatic tests * helps with some Kotlin conversion with classes under test down the line, as Kotlin Mockito handles things like nullability etc properly Differential Revision: D67824679
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67824679 |
|
This pull request has been merged in e99b47c. |
|
This pull request was successfully merged by @rshest in e99b47c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This makes the
RootViewTestandJSPointerDispatchertests to use mockito-kotlin instead of the Java Mockito, which is the legacy of the conversion of the corresponding tests from Java.Which:
Differential Revision: D67824679