Improve error messages in expect().toThrow(message) #48430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67738146 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 2, 2025
Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Differential Revision: D67738146
Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Reviewed By: rshest Differential Revision: D67738146
rubennorte
force-pushed
the
export-D67738146
branch
from
e4d73b9 to
fea0295
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
…ok#48430) Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Reviewed By: rshest Differential Revision: D67738146
|
This pull request was exported from Phabricator. Differential Revision: D67738146 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
…ok#48430) Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Reviewed By: rshest Differential Revision: D67738146
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
…ok#48430) Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Reviewed By: rshest Differential Revision: D67738146
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 3, 2025
…ok#48430) Summary: Changelog: [internal] This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.: * Before: "Expected <function> to throw" * After: "Expected <function> to throw with message 'foo', but threw with message 'bar'" Reviewed By: rshest Differential Revision: D67738146
|
This pull request has been merged in f20486c. |
|
This pull request was successfully merged by @rubennorte in f20486c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This expectation currently prints a very generic message that is hard to parse, so this change improves it a bit to account for more cases. E.g.:
Differential Revision: D67738146