Add createFromUtf16 JSI method #48211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 11, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
80ce4e2 to
1ea63f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 11, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
1ea63f5 to
74fa20b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 11, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
74fa20b to
5683384
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
|
🥳 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 11, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
5683384 to
3fac4b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
force-pushed
the
export-D67070206
branch
from
3fac4b7 to
ab13a02
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 14, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 14, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
ab13a02 to
967a91c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
force-pushed
the
export-D67070206
branch
from
967a91c to
711da8f
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Differential Revision: D67070206
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
force-pushed
the
export-D67070206
branch
from
711da8f to
7647ff3
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Dec 16, 2024
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
force-pushed
the
export-D67070206
branch
from
7647ff3 to
4a28cab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Jan 16, 2025
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
4a28cab to
06d211e
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Jan 17, 2025
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
tsaichien
force-pushed
the
export-D67070206
branch
from
06d211e to
5e083c9
Compare
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Jan 22, 2025
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
tsaichien
added a commit
to tsaichien/react-native
that referenced
this pull request
Jan 22, 2025
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
5e083c9 to
dd5eddf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
Summary: Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206
tsaichien
force-pushed
the
export-D67070206
branch
from
dd5eddf to
a66bef3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67070206 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jan 23, 2025
Summary: X-link: facebook/react-native#48211 Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206 fbshipit-source-id: 47297e6ae3028ee0e101628aab5bc076fcbbdebc
|
This pull request has been merged in d9d8240. |
|
This pull request was successfully merged by @tsaichien in d9d8240 When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jan 23, 2025
Summary: X-link: facebook/react-native#48211 Adding the default implementation for `createFromUtf16` method for JSI String and PropNameId. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D67070206 fbshipit-source-id: 47297e6ae3028ee0e101628aab5bc076fcbbdebc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding the default implementation for
createFromUtf16method for JSIString and PropNameId.
Differential Revision: D67070206