Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native sync for revisions de68d2f...372ec00 #48196

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ packages/react-native/ReactAndroid/build
packages/react-native/ReactAndroid/hermes-engine/build/
packages/react-native/Libraries/Renderer/*
packages/react-native/Libraries/vendor/**/*
packages/react-native-fantom/**/*
node_modules/
packages/*/node_modules
packages/*/dist
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@
"nullthrows": "^1.1.1",
"prettier": "2.8.8",
"prettier-plugin-hermes-parser": "0.25.1",
"react": "18.3.1",
"react-test-renderer": "18.3.1",
"react": "19.0.0",
"react-test-renderer": "19.0.0",
"rimraf": "^3.0.2",
"shelljs": "^0.8.5",
"signedsource": "^1.0.0",
Expand All @@ -106,6 +106,6 @@
"ws": "^6.2.3"
},
"resolutions": {
"react-is": "18.3.1"
"react-is": "19.0.0"
}
}
4 changes: 2 additions & 2 deletions packages/helloworld/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"test": "jest"
},
"dependencies": {
"react": "18.3.1",
"react": "19.0.0",
"react-native": "1000.0.0"
},
"devDependencies": {
Expand All @@ -28,7 +28,7 @@
"eslint": "^8.19.0",
"jest": "^29.6.3",
"listr2": "^8.2.1",
"react-test-renderer": "18.3.1",
"react-test-renderer": "19.0.0",
"rxjs": "^7.8.1"
},
"engines": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@
(console: any).warn = warn;
});

it('integrates with React and handles a key error in LogBox', () => {
// TODO: migrate this test to react-native-fantom
// The test has been disabled because it was actually using the react-test-renderer
// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a key error in LogBox', () => {

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

View workflow job for this annotation

GitHub Actions / test_js (20)

Disabled test

Check warning on line 66 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

View workflow job for this annotation

GitHub Actions / test_js (18)

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();

Expand Down Expand Up @@ -114,7 +119,12 @@
]);
});

it('integrates with React and handles a fragment warning in LogBox', () => {
// TODO: migrate this test to react-native-fantom
// The test has been disabled because it was actually using the react-test-renderer
// and testing the react-test-renderer instead of the real one.
// The react test renderer is now deprecated, so there is no value in keeping this test
// as it is.
it.skip('integrates with React and handles a fragment warning in LogBox', () => {

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

View workflow job for this annotation

GitHub Actions / test_js (20)

Disabled test

Check warning on line 127 in packages/react-native/Libraries/LogBox/__tests__/LogBox-integration-test.js

View workflow job for this annotation

GitHub Actions / test_js (18)

Disabled test
const spy = jest.spyOn(LogBoxData, 'addLog');
installLogBox();

Expand Down
Loading
Loading