Delete tests migrated to Fantom and unnecessary mocks for FabricUIManager, DOM, etc. #48087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66599197 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 4, 2024
…ager, DOM, etc. (facebook#48087) Summary: Changelog: [internal] Now that we have Fantom tests for these unit tests that use mocks, we can remove the JS tests and the mocks :) Reviewed By: sammy-SC Differential Revision: D66599197
rubennorte
force-pushed
the
export-D66599197
branch
from
8a03823 to
fc62de8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66599197 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 4, 2024
…ager, DOM, etc. (facebook#48087) Summary: Changelog: [internal] Now that we have Fantom tests for these unit tests that use mocks, we can remove the JS tests and the mocks :) Reviewed By: sammy-SC Differential Revision: D66599197
rubennorte
force-pushed
the
export-D66599197
branch
from
fc62de8 to
1f42415
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66599197 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 4, 2024
…ager, DOM, etc. (facebook#48087) Summary: Changelog: [internal] Now that we have Fantom tests for these unit tests that use mocks, we can remove the JS tests and the mocks :) Reviewed By: sammy-SC Differential Revision: D66599197
rubennorte
force-pushed
the
export-D66599197
branch
from
1f42415 to
fc2bad9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66599197 |
…acebook#48063) Summary: Changelog: [internal] This allows async functions to be passed to `runTask` (just a type change really) and adds tests for ReactNativeTester. Error handling isn't currently set up correctly, so those tests are disabled for now. Reviewed By: sammy-SC Differential Revision: D66698547
…setup to standalone modules (facebook#48083) Summary: Changelog: [internal] Just a small refactor to have a better code organization for the testing runtime infra. Reviewed By: sammy-SC Differential Revision: D66753269
…facebook#48086) Summary: Changelog: [internal] Just adding a bit of coverage for the `expect` API adding `toBeLessThan` and `toBeGreaterThan`. Reviewed By: sammy-SC Differential Revision: D66753268
…ager, DOM, etc. (facebook#48087) Summary: Changelog: [internal] Now that we have Fantom tests for these unit tests that use mocks, we can remove the JS tests and the mocks :) Reviewed By: sammy-SC Differential Revision: D66599197
rubennorte
force-pushed
the
export-D66599197
branch
from
fc2bad9 to
d77f499
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66599197 |
|
This pull request has been merged in 2e7e065. |
|
This pull request has been reverted by ea84bc6. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 5, 2024
…ager, DOM, etc. (2nd attempt) Summary: Changelog: [internal] Re-land facebook#48087 with some CI fixes. Differential Revision: D66820310
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 9, 2024
…ager, DOM, etc. (2nd attempt) (facebook#48117) Summary: Changelog: [internal] Re-land facebook#48087 with some CI fixes. Reviewed By: rshest Differential Revision: D66820310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Now that we have Fantom tests for these unit tests that use mocks, we can remove the JS tests and the mocks :)
Reviewed By: sammy-SC
Differential Revision: D66599197