Fix Android ensureNoOverlap function and revise iOS's implementation #47989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66514729 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Nov 27, 2024
…acebook#47989) Summary: - Fixing Android's ensureNoOverlap algorithm. (For real this time) - Improve verbiage for both Android and iOS `ensureNoOverlap` functions. (iOS was unsing EdgeInset wording which is inaccurate and confusing) Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66514729
jorge-cab
force-pushed
the
export-D66514729
branch
from
065dc9a to
8adcb0e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66514729 |
jorge-cab
force-pushed
the
export-D66514729
branch
from
8adcb0e to
50732a6
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Nov 27, 2024
…acebook#47989) Summary: - Fixing Android's ensureNoOverlap algorithm. (For real this time) - Improve verbiage for both Android and iOS `ensureNoOverlap` functions. (iOS was unsing EdgeInset wording which is inaccurate and confusing) Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66514729
|
This pull request was exported from Phabricator. Differential Revision: D66514729 |
…acebook#47989) Summary: - Fixing Android's ensureNoOverlap algorithm. (For real this time) - Improve verbiage for both Android and iOS `ensureNoOverlap` functions. (iOS was unsing EdgeInset wording which is inaccurate and confusing) Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66514729
jorge-cab
force-pushed
the
export-D66514729
branch
from
50732a6 to
559dc1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66514729 |
|
This pull request has been merged in ce9f534. |
|
This pull request was successfully merged by @jorge-cab in ce9f534 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ensureNoOverlapfunctions. (iOS was unsing EdgeInset wording which is inaccurate and confusing)Changelog: [Internal]
Differential Revision: D66514729