Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal #47402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Differential Revision: D65462051
mdvacca
force-pushed
the
export-D65462051
branch
from
b1c141d to
17ec017
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
mdvacca
force-pushed
the
export-D65462051
branch
from
17ec017 to
e16df6b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
mdvacca
force-pushed
the
export-D65462051
branch
from
e16df6b to
fb4e401
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 5, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
force-pushed
the
export-D65462051
branch
from
fb4e401 to
0812e0c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 6, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
mdvacca
force-pushed
the
export-D65462051
branch
from
0812e0c to
5ef0691
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
mdvacca
force-pushed
the
export-D65462051
branch
from
5ef0691 to
c1bc298
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Nov 6, 2024
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
Summary: In this diff we are excluding the $$PropSetter classes from public API, we do this by adding the UnstableReactNativeAPI annotation on all $$PropSetter classes changelog: [internal] internal Differential Revision: D65488026
…ointernal (facebook#47402) Summary: Pull Request resolved: facebook#47402 Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal Reviewed By: cortinico Differential Revision: D65462051
mdvacca
force-pushed
the
export-D65462051
branch
from
c1bc298 to
5458b83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65462051 |
|
This pull request has been merged in 4a119c4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate ReactVirtualTextViewManager to kotlin and reduce visibility tointernal
changelog: [Android][Breaking] Reduce visibility of ReactVirtualTextViewManager to internal
Differential Revision: D65462051