Undo breaking change on ViewManagerDelegate.kt String params #47086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When we migrated `ViewManagerDelegate` to Kotlin, we convered his string params to be `String` (rather than `String?`). Existing implementation of this interface in OSS written in Kotlin were using `String?` due to this interface being in Java (and not being Nullsafe annotated). Therefore now changing this interface from `String?` to `String` is a breaking change for them. Affected libraries are: https://github.com/search?q=%22fun+receiveCommand%28%22+%22commandId%3A+String%3F%22+%22args%3A+ReadableArray%22+language%3Akotlin+-org%3Afacebook+-is%3Afork&type=code&p=4 This prevents the breaking change and should be included in 0.76. Changelog: [Android] [Fixed] - Undo breaking change on ViewManagerDelegate.kt String params Differential Revision: D64532446
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64532446 |
3 tasks
|
This pull request has been merged in 2d2bb9c. |
|
This pull request was successfully merged by @cortinico in 2d2bb9c When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Oct 17, 2024
Summary: Pull Request resolved: #47086 When we migrated `ViewManagerDelegate` to Kotlin, we convered his string params to be `String` (rather than `String?`). Existing implementation of this interface in OSS written in Kotlin were using `String?` due to this interface being in Java (and not being Nullsafe annotated). Therefore now changing this interface from `String?` to `String` is a breaking change for them. Affected libraries are: https://github.com/search?q=%22fun+receiveCommand%28%22+%22commandId%3A+String%3F%22+%22args%3A+ReadableArray%22+language%3Akotlin+-org%3Afacebook+-is%3Afork&type=code&p=4 This prevents the breaking change and should be included in 0.76. Changelog: [Android] [Fixed] - Undo breaking change on ViewManagerDelegate.kt String params Reviewed By: cipolleschi Differential Revision: D64532446 fbshipit-source-id: aac286554ad0e35f557160f900bcbad1acc5930d
|
This pull request was successfully merged by @cortinico in ce16206 When will my fix make it into a release? | How to file a pick request? |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 10, 2025
Summary: See context in D64532446 / facebook#47086 These argument types were already consumed as nullable in various OSS libraries, which prevents correct Kotlin migration of this code. Changelog: [Android][Changed] Deprecated ViewManagerDelegate#setProperty and ViewManagerDelegate#receiveCommand Differential Revision: D67277871
javache
added a commit
to javache/react-native
that referenced
this pull request
Jan 13, 2025
Summary: See context in D64532446 / facebook#47086 These argument types were already consumed as nullable in various OSS libraries, which prevents correct Kotlin migration of this code. Changelog: [Android][Changed] Deprecated ViewManagerDelegate#setProperty and ViewManagerDelegate#receiveCommand Reviewed By: mdvacca Differential Revision: D67277871
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Summary: Pull Request resolved: #48602 See context in D64532446 / #47086 These argument types were already consumed as nullable in various OSS libraries, which prevents correct Kotlin migration of this code. Changelog: [Android][Changed] Deprecated ViewManagerDelegate#setProperty and ViewManagerDelegate#receiveCommand Reviewed By: mdvacca Differential Revision: D67277871 fbshipit-source-id: a0743584891c7b2b4b50fff11de15da0078d5a1a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we migrated
ViewManagerDelegateto Kotlin, we convered his string params to beString(rather thanString?).Existing implementation of this interface in OSS written in Kotlin were using
String?due to this interface being in Java (and not being Nullsafe annotated).Therefore now changing this interface from
String?toStringis a breaking change for them.Affected libraries are:
https://github.com/search?q=%22fun+receiveCommand%28%22+%22commandId%3A+String%3F%22+%22args%3A+ReadableArray%22+language%3Akotlin+-org%3Afacebook+-is%3Afork&type=code&p=4
This prevents the breaking change and should be included in 0.76.
Changelog:
[Android] [Fixed] - Undo breaking change on ViewManagerDelegate.kt String params
Differential Revision: D64532446