[Android] Fix Headless Crash Tried to finish non-existent task with id

[RodolfoGS]

Summary:

Sometimes a headless task tries to finish, but it doesn’t exist, which causes an exception.
No one knows how to reliably reproduce it, as it could be a race condition. However, if you attempt to remove a task that has already been removed, it shouldn’t cause an issue since you're trying to remove something that’s already gone (which is exactly what you want).

Fixes:

• [Android] Headless Crash Tried to finish non-existent task with id #46496
• Android HeadlessJS Crash - Tried to finish non-existent task with id #33883
• Android HeadlessJS Crash - Tried to finish non-existent task with id #27597
• Android Crash - Tried to finish non-existent task with id 2 transistorsoft/react-native-background-fetch#202
• Fatal Exception: Tried to finish non-existent task with id 1 transistorsoft/react-native-background-fetch#369
• Tried to finish non-existent task with id x transistorsoft/react-native-background-geolocation#2096
• [Android] App crash scenario jpush/jpush-react-native#78

Stacktrace:

Fatal Exception: java.lang.AssertionError: Tried to finish non-existent task with id 28.
  at com.facebook.infer.annotation.Assertions.assertCondition(Assertions.java:88)
  at com.facebook.react.jstasks.HeadlessJsTaskContext.finishTask(HeadlessJsTaskContext.java:179)
  at com.facebook.react.jstasks.HeadlessJsTaskContext$3.run(HeadlessJsTaskContext.java:217)
  at android.os.Handler.handleCallback(Handler.java:958)
  at android.os.Handler.dispatchMessage(Handler.java:99)
  at android.os.Looper.loopOnce(Looper.java:257)
  at android.os.Looper.loop(Looper.java:368)
  at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:233)
  at java.lang.Thread.run(Thread.java:1012)

Screenshot

Screen.Recording.2024-09-14.at.12.56.27.PM.mov

Changelog:

[ANDROID] [FIXED] - Fix Headless Crash Tried to finish non-existent task with id

Test Plan:

I created an example where I attempt to remove a task that doesn’t exist.

Example: https://github.com/RodolfoGS/react-native-fix-non-existent-task

How to reproduce using the example above:

1. git clone [email protected]:RodolfoGS/react-native-fix-non-existent-task.git
2. cd react-native-fix-non-existent-task
3. npm install
4. npm run android
5. Notice the crash

Steps to create the example from scratch and reproduce the crash:

1. npx @react-native-community/cli@latest init AwesomeProject
2. cd AwesomeProject
3. Add call to finishTask to reproduce the crash (RodolfoGS/react-native-fix-non-existent-task@6fe3c13)
4. npm run android
5. Notice the crash

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cortinico]

LGTM 👍

[facebook-github-bot]

@rshest merged this pull request in b4532ad.

[react-native-bot]

This pull request was successfully merged by @RodolfoGS in b4532ad

^{When will my fix make it into a release? | How to file a pick request?}