fix: RNGP autolink not properly filter out pure C++ TurboModules #46381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
2 tasks
The react-native gradle plugin didn't properly filter out Pure C++ TurboModules for autolinking, which caused build failures as a non-existing gradle dependency would be emitted.
hsjoberg
force-pushed
the
fix-purecxx-autolink
branch
from
c2b90d4 to
0ca896c
Compare
cortinico
approved these changes
Sep 9, 2024
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 833c3a2. |
|
This pull request was successfully merged by @hsjoberg in 833c3a2 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
) Summary: Hey. The react-native gradle plugin didn't properly filter out [Pure](react-native-community/cli#2387) C++ TurboModules for autolinking, which caused build failures as a non-existing gradle dependency would be emitted. This makes Pure C++ TurboModules work again for Android. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID][FIXED] Fix autolinking issues for Pure C++ TurboModules Pull Request resolved: #46381 Test Plan: https://github.com/hsjoberg/rn75autolinkregression Try running this repro project to observe the error: ``` 1: Task failed with an exception. ----------- * Where: Build file '/Users/coco/Projects/Blixt/rn75autolinkregression/example/android/app/build.gradle' line: 54 * What went wrong: A problem occurred evaluating project ':app'. > Project with path ':react-native-cxx-turbomodule' could not be found in project ':app'. ``` Simply add the 1-line code from this PR to make the build succeed. Cheers. Reviewed By: cipolleschi Differential Revision: D62377757 Pulled By: cortinico fbshipit-source-id: 9e3fa3777b4e6e4d3f2eb0f996ac0ac7676eedbe
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
) Summary: Hey. The react-native gradle plugin didn't properly filter out [Pure](react-native-community/cli#2387) C++ TurboModules for autolinking, which caused build failures as a non-existing gradle dependency would be emitted. This makes Pure C++ TurboModules work again for Android. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID][FIXED] Fix autolinking issues for Pure C++ TurboModules Pull Request resolved: #46381 Test Plan: https://github.com/hsjoberg/rn75autolinkregression Try running this repro project to observe the error: ``` 1: Task failed with an exception. ----------- * Where: Build file '/Users/coco/Projects/Blixt/rn75autolinkregression/example/android/app/build.gradle' line: 54 * What went wrong: A problem occurred evaluating project ':app'. > Project with path ':react-native-cxx-turbomodule' could not be found in project ':app'. ``` Simply add the 1-line code from this PR to make the build succeed. Cheers. Reviewed By: cipolleschi Differential Revision: D62377757 Pulled By: cortinico fbshipit-source-id: 9e3fa3777b4e6e4d3f2eb0f996ac0ac7676eedbe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey.
Summary:
The react-native gradle plugin didn't properly filter out Pure C++ TurboModules for autolinking, which caused build failures as a non-existing gradle dependency would be emitted.
This makes Pure C++ TurboModules work again for Android.
Changelog:
[ANDROID][FIXED] Fix autolinking issues for Pure C++ TurboModules
Test Plan:
https://github.com/hsjoberg/rn75autolinkregression
Try running this repro project to observe the error:
Simply add the 1-line code from this PR to make the build succeed.
Cheers.