Make StaticViewConfigValidator permissive of extra attributes on SVC compared to native viewconfig #45859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60575253 |
|
This pull request was exported from Phabricator. Differential Revision: D60575253 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 17, 2024
…compared to native viewconfig (facebook#45859) Summary: Pull Request resolved: facebook#45859 "Fabric without SVCs" configuration is nearly gone, and so it doesn't make sense to need to add no-op methods, on normally Paper only code, etc to satisfy native viewconfig. These particular warnings are then more often noise, than things we need to action on. Checking for native code to be present can also break development where users are using distributed native app, slightly older than JS. This keeps the warning, only if static viewconfigs are missing native view config attributes (i.e. new prop would only be exposed to Paper, instead of only exposed to Fabric) Changelog: [Internal] Differential Revision: D60575253
NickGerleman
force-pushed
the
export-D60575253
branch
from
814d500 to
40e141a
Compare
…compared to native viewconfig (facebook#45859) Summary: Pull Request resolved: facebook#45859 "Fabric without SVCs" configuration is nearly gone, and so it doesn't make sense to need to add no-op methods, on normally Paper only code, etc to satisfy native viewconfig. These particular warnings are then more often noise, than things we need to action on. Checking for native code to be present can also break development where users are using distributed native app, slightly older than JS. This keeps the warning, only if static viewconfigs are missing native view config attributes (i.e. new prop would only be exposed to Paper, instead of only exposed to Fabric) Changelog: [Internal] Reviewed By: javache Differential Revision: D60575253
|
This pull request was exported from Phabricator. Differential Revision: D60575253 |
NickGerleman
force-pushed
the
export-D60575253
branch
from
40e141a to
f4dc34c
Compare
|
This pull request has been merged in 387560a. |
|
This pull request was successfully merged by @NickGerleman in 387560a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
"Fabric without SVCs" configuration is nearly gone, and so it doesn't make sense to need to add no-op methods, on normally Paper only code, etc to satisfy native viewconfig. These particular warnings are then more often noise, than things we need to action on.
Checking for native code to be present can also break development where users are using distributed native app, slightly older than JS.
This keeps the warning, only if static viewconfigs are missing native view config attributes (i.e. new prop would only be exposed to Paper, instead of only exposed to Fabric)
Changelog: [Internal]
Differential Revision: D60575253