Add EventEmitter Code-gen support for Java and ObjC Turbo Modules #45119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58929417 |
Base commit: b5683a7 |
|
This pull request was exported from Phabricator. Differential Revision: D58929417 |
christophpurrer
force-pushed
the
export-D58929417
branch
from
cd4c42e to
1e9822d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 24, 2024
…cebook#45119) Summary: Pull Request resolved: facebook#45119 ## Changelog: [iOS][Added] - Add EventEmitter Code-gen support for Java and ObjC Turbo Modules Differential Revision: D58929417
|
This pull request was exported from Phabricator. Differential Revision: D58929417 |
christophpurrer
force-pushed
the
export-D58929417
branch
from
1e9822d to
145265f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 24, 2024
…cebook#45119) Summary: Pull Request resolved: facebook#45119 ## Changelog: [iOS][Added] - Add EventEmitter Code-gen support for Java and ObjC Turbo Modules Differential Revision: D58929417
Summary: Shows a proof of concept how '*strongly typed Turbo Module scoped*' `EventEmitters` can be used in a Java Turbo Module. ## Changelog: [Android] [Added] - Add Java Turbo Module Event Emitter example Differential Revision: D57530807
…acebook#45113) Summary: Pull Request resolved: facebook#45113 ## Changelog: [iOS][Added] - Code-generate an optional base class to use for every NativeModule Extend RN Code-gen to generate a NativeModule base class for each ObjC Turbo Modules. Its usage is not mandatory now, but would become for future features to add A practial first step would be to migrate https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/nativemodule/core/platform/ios/ReactCommon/RCTTurboModule.h#L157-L160 from the `protocol` to the default `interface` and then provide a default implementation for it Differential Revision: D58907395
Differential Revision: D57650830
|
This pull request was exported from Phabricator. Differential Revision: D58929417 |
christophpurrer
force-pushed
the
export-D58929417
branch
from
145265f to
8de9dab
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jun 26, 2024
…cebook#45119) Summary: Pull Request resolved: facebook#45119 ## Changelog: [iOS][Added] - Add EventEmitter Code-gen support for Java and ObjC Turbo Modules Differential Revision: D58929417
…cebook#45119) Summary: Pull Request resolved: facebook#45119 ## Changelog: [iOS][Added] - Add EventEmitter Code-gen support for Java and ObjC Turbo Modules Differential Revision: D58929417
|
This pull request was exported from Phabricator. Differential Revision: D58929417 |
christophpurrer
force-pushed
the
export-D58929417
branch
from
8de9dab to
beaa7f7
Compare
|
This pull request has been merged in ad3df84. |
|
This pull request was successfully merged by @christophpurrer in ad3df84. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[iOS][Added] - Add EventEmitter Code-gen support for Java and ObjC Turbo Modules
Differential Revision: D58929417