fix TextInput 'contextMenuHidden' prop #45014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58684366 |
Base commit: 8c7c6f3 |
Summary: Pull Request resolved: facebook#45014 `TextInput`'s `contextMenuHidden` prop is working working as expected. It should hide the context menu (copy/paste/...) that pops up from input text. Reference: [Android doc](https://developer.android.com/reference/android/widget/TextView#setCustomSelectionActionModeCallback(android.view.ActionMode.Callback)) > Returning false from `ActionMode.Callback.onCreateActionMode(ActionMode, android.view.Menu)` will prevent the action mode from being started. **Changelog:** [Android][Fixed] - TextInput's `contextMenuHidden` prop bug fix Differential Revision: D58684366
|
This pull request was exported from Phabricator. Differential Revision: D58684366 |
alanleedev
force-pushed
the
export-D58684366
branch
from
79ea008 to
e29b9e1
Compare
|
This pull request has been merged in 8a3ffb6. |
|
This pull request was successfully merged by @alanleedev in 8a3ffb6. When will my fix make it into a release? | How to file a pick request? |
This was referenced Sep 25, 2024
Closed
blakef
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: #45014 `TextInput`'s `contextMenuHidden` prop isn't working working as expected. It should hide the context menu (copy/paste/...) that pops up from input text. Reference: [Android doc](https://developer.android.com/reference/android/widget/TextView#setCustomSelectionActionModeCallback(android.view.ActionMode.Callback)) > Returning false from `ActionMode.Callback.onCreateActionMode(ActionMode, android.view.Menu)` will prevent the action mode from being started. **Changelog:** [Android][Fixed] - TextInput's `contextMenuHidden` prop bug fix Reviewed By: javache Differential Revision: D58684366 fbshipit-source-id: 328c267ed0e896a78e114578e3a00adf41f2e095
cipolleschi
pushed a commit
that referenced
this pull request
Oct 7, 2024
Summary: Pull Request resolved: #45014 `TextInput`'s `contextMenuHidden` prop isn't working working as expected. It should hide the context menu (copy/paste/...) that pops up from input text. Reference: [Android doc](https://developer.android.com/reference/android/widget/TextView#setCustomSelectionActionModeCallback(android.view.ActionMode.Callback)) > Returning false from `ActionMode.Callback.onCreateActionMode(ActionMode, android.view.Menu)` will prevent the action mode from being started. **Changelog:** [Android][Fixed] - TextInput's `contextMenuHidden` prop bug fix Reviewed By: javache Differential Revision: D58684366 fbshipit-source-id: 328c267ed0e896a78e114578e3a00adf41f2e095
2 tasks
kirillzyusko
added a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Nov 15, 2024
## 📜 Description Update `react-native` to `0.76.2`. ## 💡 Motivation and Context To stay up-do-date with ecosystem. Key points: - enabled Hermes on Android (JSC was crashing app on startup); - enable `contextMenuHidden` only on iOS (see facebook/react-native#45014 - now if we select entire text the cursor gets moved to the end and we don't handle the event when cursor is located in the end). ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - update all deps to its latest versions; ### Android - enabled Hermes, since we get a crash on startup. ## 🤔 How Has This Been Tested? tested on: - CI; - Pixel 7 Pro (Android 15); - iPhone 6s (iOS 15.8); ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TextInput'scontextMenuHiddenprop is not working working as expected.It should hide the context menu (copy/paste/...) that pops up from input text.
Changelog: [Android][Fixed] - TextInput's
contextMenuHiddenprop bug fixDifferential Revision: D58684366