Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not invoke envinfo on windows #42984

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
CI is broken. Let's not bother attempting to fixing it as it's attempting to call envinfo on Windows
which no one really looks into.
Also the maintainer is unresponsive: tabrindle/envinfo#238

Changelog:
[Internal] [Changed] - Do not invoke envinfo on windows

Differential Revision: D53698194

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 13, 2024
Summary:
CI is broken. Let's not bother attempting to fixing it as it's attempting to call `envinfo` on Windows
which no one really looks into.
Also the maintainer is unresponsive: tabrindle/envinfo#238

Changelog:
[Internal] [Changed] - Do not invoke envinfo on windows

Reviewed By: cipolleschi

Differential Revision: D53698194
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,238,557 +2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,980 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f32950a
Branch: main

@cortinico
Copy link
Contributor Author

0575033

@cortinico cortinico closed this Feb 13, 2024
@cortinico cortinico added the Merged This PR has been merged. label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants