-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RN][iOS] Fix warning when loading RCTUIManager and A11yManager #42734
Conversation
Base commit: 4c108aa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for fixing this 👍
Hi! which install RN 0.73.3, I get the error in the physical device and also in the simulator. I don't think it is related to RN-Reanimated library btw |
Summary:
When we fixed the race condition between A11yManager and RCTUIManager, we did it by moving the A11yManager on a background queue.
In the old architecture, this was raising a warning which our users might find confusing. Plus, that change was not aligned with what the A11yManager declared in its configuration because we are actually initializing it starting from a BG queue.
With this change we anticipate the initialization of the module in a place where:
This should allow us to also remove the feature flag of RCTUIManagerDispatchAccessibilityManagerInitOntoMain because now it is safe to use the main_queue as requested by the module.
Changelog:
[iOS][Fixed] - Initialize the A11yManager in the main queue and when we need it.
Test Plan:
Tested in an app running 0.73.3, using the following configurations: