Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate enableSpannableBuildingUnification to new feature flag system #42716

Closed
wants to merge 1 commit into from

Conversation

NickGerleman
Copy link
Contributor

Summary:
Migrates this to the new flag system just added.

Made a quick change to the Android template, to mark Kotlin accessors as JvmStatic to make calling from Java more idiomatic.

Next diff will wire to MC.

Changelog: [Internal]

Reviewed By: rubennorte, mdvacca

Differential Revision: D53198874

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53198874

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Jan 29, 2024

Verified

This commit was signed with the committer’s verified signature.
Exirel Florian Strzelecki
…em (facebook#42716)

Summary:

Migrates this to the new flag system just added.

Made a quick change to the Android template, to mark Kotlin accessors as `JvmStatic` to make calling from Java more idiomatic.

Next diff will wire to MC.

Changelog: [Internal]

Reviewed By: rubennorte, mdvacca

Differential Revision: D53198874
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53198874

@analysis-bot
Copy link

analysis-bot commented Jan 29, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,084,501 +4,100
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,463,853 +4,102
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3a789a1
Branch: main

…em (facebook#42716)

Summary:

Migrates this to the new flag system just added.

Made a quick change to the Android template, to mark Kotlin accessors as `JvmStatic` to make calling from Java more idiomatic.

Next diff will wire to MC.

Changelog: [Internal]

Reviewed By: rubennorte, mdvacca

Differential Revision: D53198874
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53198874

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 30, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in daa3080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants