Remove RCTAppSetupPrepareApp overload and InspectorFlags call #42642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
Base commit: db066ac |
| @@ -87,7 +87,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:( | |||
|
|
|||
| NSDictionary *initProps = updateInitialProps([self prepareInitialProps], fabricEnabled); | |||
|
|
|||
| RCTAppSetupPrepareApp(application, enableTM, *_reactNativeConfig); | |||
| RCTAppSetupPrepareApp(application, enableTM); | |||
There was a problem hiding this comment.
Oh nice! This will make my PR easier #42263 (no need to separate this logic to another function). Commenting here to get notified when it gets merged 👍🏻
There was a problem hiding this comment.
Great :D It'll get merged as soon as I sort out the PR that's stacked with this (failing internal CI in a tricky way).
huntie
force-pushed
the
export-D53048207
branch
from
01c90b1 to
047924c
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 25, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Differential Revision: D53048207
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 25, 2024
…ok#42642) Summary: Pull Request resolved: facebook#42642 Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Differential Revision: D53048207 fbshipit-source-id: 8ed5e3874c7c8e8bd24556ea25c2818823f299b4
huntie
force-pushed
the
export-D53048207
branch
from
047924c to
48315ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 26, 2024
…ok#42642) Summary: Pull Request resolved: facebook#42642 Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Differential Revision: D53048207 fbshipit-source-id: 457f55cbccea8b5b3fbfbbd0c44c5b98dff6834a
huntie
force-pushed
the
export-D53048207
branch
from
48315ad to
26a3db3
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 29, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Differential Revision: D53048207
huntie
force-pushed
the
export-D53048207
branch
from
26a3db3 to
1ba9a16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 29, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Differential Revision: D53048207
huntie
force-pushed
the
export-D53048207
branch
from
1ba9a16 to
3451009
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 29, 2024
…ll (facebook#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Reviewed By: motiz88 Differential Revision: D53048207
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jan 30, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Reviewed By: motiz88 Differential Revision: D53048207
huntie
force-pushed
the
export-D53048207
branch
from
3451009 to
c35b5b8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 2, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Reviewed By: motiz88 Differential Revision: D53048207
huntie
force-pushed
the
export-D53048207
branch
from
c35b5b8 to
f4c6290
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
huntie
force-pushed
the
export-D53048207
branch
from
f4c6290 to
1a6730c
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 5, 2024
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Reviewed By: motiz88 Differential Revision: D53048207
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
…ok#42642) Summary: Removes call to `InspectorFlags::initFromConfig`, since this approach is being replaced with `ReactNativeFeatureFlags`. This change is separated out as it originally made a public API deprecation. Changelog: [iOS][Deprecated] - **Un-deprecates** `RCTAppSetupPrepareApp` (reverts facebook#41976) Reviewed By: motiz88 Differential Revision: D53048207
huntie
force-pushed
the
export-D53048207
branch
from
1a6730c to
b73a9e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53048207 |
|
This pull request has been merged in ce3ce11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removes call to
InspectorFlags::initFromConfig, since this approach is being replaced withReactNativeFeatureFlags. This change is separated out as it originally made a public API deprecation.Changelog:
[iOS][Deprecated] - Un-deprecates
RCTAppSetupPrepareApp(reverts #41976)Differential Revision: D53048207