New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'[skip ci] [RN][C++] Fix UIManagerBinding'\''s findNodeAtPoint #42439

Closed

RSNara wants to merge 3 commits into facebook:main from RSNara:export-D52909512

Contributor

RSNara commented Jan 20, 2024

Summary:
UIManagerBinding'''s findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See LayoutableShadowNode::findNodeAtPoint:

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

facebook-github-bot added the fb-exported label

RSNara force-pushed the export-D52909512 branch from f7727bf to d083d5b Compare

January 20, 2024 23:14

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from d083d5b to a2d8a62 Compare

January 20, 2024 23:26

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

1 similar comment

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          '[skip ci] [RN][C++] Fix UIManagerBinding'\''s findNodeAtPoint (faceb…

9237bf6

…ook#42439)

Summary:
Pull Request resolved: facebook#42439

UIManagerBinding'\''s findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

fbshipit-source-id: f7fdede23af80e78ebb02aa27aaac6a116797f5a

RSNara force-pushed the export-D52909512 branch 2 times, most recently from 9237bf6 to 1fae9eb Compare

January 20, 2024 23:35

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

1fae9eb

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

ddf796b

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

1 similar comment

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          '[skip ci] [RN][C++] Fix UIManagerBinding'\''s findNodeAtPoint (faceb…

a520b35

…ook#42439)

Summary:
Pull Request resolved: facebook#42439

UIManagerBinding'\''s findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

fbshipit-source-id: c8d53f8f417262a974ad1f36ea783bb3837108f2

RSNara force-pushed the export-D52909512 branch 2 times, most recently from a520b35 to 402af14 Compare

January 20, 2024 23:42

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

402af14

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

10c1a02

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

062cece

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 402af14 to 062cece Compare

January 20, 2024 23:44

Contributor

facebook-github-bot commented Jan 20, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

5b923ca

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          [skip ci] Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

1b79899

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

76d8204

Summary:
Pull Request resolved: facebook#42439

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Differential Revision: D52909512

Reviewed By: cortinico, sammy-SC

fbshipit-source-id: 6a05c9215ac1ad6726d00bc6db7a9a2fdb68b30d

RSNara force-pushed the export-D52909512 branch from 062cece to 2d54fd9 Compare

January 21, 2024 00:00

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

ac5f981

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from a0ca5d0 to ac5f981 Compare

January 23, 2024 16:06

Contributor

facebook-github-bot commented Jan 23, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

2ac9e99

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from ac5f981 to 2ac9e99 Compare

January 23, 2024 21:36

Contributor

facebook-github-bot commented Jan 23, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

93d72fa

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 2ac9e99 to 93d72fa Compare

January 23, 2024 23:03

Contributor

facebook-github-bot commented Jan 23, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

6fe2ac7

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 93d72fa to 6fe2ac7 Compare

January 24, 2024 17:09

Contributor

facebook-github-bot commented Jan 24, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

6ecdb6b

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 6fe2ac7 to 6ecdb6b Compare

January 24, 2024 17:10

Contributor

facebook-github-bot commented Jan 24, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

3f6d634

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 6ecdb6b to 3f6d634 Compare

January 24, 2024 23:19

Contributor

facebook-github-bot commented Jan 24, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 3f6d634 to 82e6707 Compare

January 25, 2024 21:37

RSNara added a commit to RSNara/react-native that referenced this pull request


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

82e6707

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

Contributor

facebook-github-bot commented Jan 25, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

RSNara added 3 commits

January 25, 2024 15:10


          [skip ci] Finish lazilyLoadView

7a80dd6

Summary:
This API was used by the old architecture to lazily register/load components:
1. Load a ViewManager's class from the disk
2. Register the ViewManager's class with React Native

See: [RCTUIManager lazilyLoadView](https://github.com/facebook/react-native/blob/822bf52c29729d25b2bfb31655cf773609a9283d/packages/react-native/React/Modules/RCTUIManager.m#L1546-L1591)

The new architecture **does not** support lazy loading of **legacy** modules/components.

Therefore, let's leave this API unimplemented until we decide to implement lazy loading of legacy stuff in new architecture.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D52677515


          [skip ci] UIManagerJSInterface: Fix getConstantsForViewManager types

a3b5869

Summary:
If Flow can be trusted, getConstantsForViewManager always gets called with a non-null string:
1. The only call-site to getConstantsForViewManager is getViewManagerConfig: [PaperUIManager.js](https://github.com/facebook/react-native/blob/822bf52c29729d25b2bfb31655cf773609a9283d/packages/react-native/Libraries/ReactNative/PaperUIManager.js#L36-L80)
2. And getViewManagerConfig always passes in a non-null string.

So, let's just make the native argument type a non-nullable string.

Thoughts?

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D52628937


          Fix UIManagerBinding's findNodeAtPoint (facebook#42439)

6c5ed64

Summary:

UIManagerBinding's findNodeAtPoint assumes that UIManager::findNodeAtPoint returns non-null pointers. But, this is false! See [LayoutableShadowNode::findNodeAtPoint](https://github.com/facebook/react-native/blob/fd0ca4dd6209d79ac8c93dbffac2e3dca1caeadc/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp#L333-L354):

https://www.internalfb.com/code/fbsource/[7169da7945c813b35cd0a4fa15e66969c90c2481]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp?lines=333%2C354

Changelog: [General][Fixed] Fix UIManagerBinding's findNodeAtPoint

Reviewed By: cortinico, sammy-SC

Differential Revision: D52909512

RSNara force-pushed the export-D52909512 branch from 82e6707 to 6c5ed64 Compare

January 25, 2024 23:10

Contributor

facebook-github-bot commented Jan 25, 2024

This pull request was exported from Phabricator. Differential Revision: D52909512

facebook-github-bot closed this in

62e5980

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Jan 26, 2024

This pull request has been merged in 62e5980.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner