[RN][iOS] Fix React-FabricImage dependencies #41641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the porting of #41640 to 0.73
react-native-svg
reported that the SVG library was not building on the latest RC of React Native because Codegen was not finding the proper files.By inspecting an example app with SVG, we realized that React-Codegen was not depending on
React-FabricImage
, while having access to their headers.We added the dependency, but them the build was failing due to a circular dependency because the
React-ImageManager
was dependeing onReact-RCTImage
.This dependency is conceptually wrong (a piece of Core should not depend on Library which depends on Core... 😑) and I verified that by removing that dependency the framework continue to build.
Changelog:
[Internal] - Fixed dependencies of Codegen on React-Image
Test Plan
Tested on a local app + CircleCI