Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS] Fix React-FabricImage dependencies #41641

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Nov 24, 2023

Summary:

This is the porting of #41640 to 0.73

react-native-svg reported that the SVG library was not building on the latest RC of React Native because Codegen was not finding the proper files.

By inspecting an example app with SVG, we realized that React-Codegen was not depending on React-FabricImage, while having access to their headers.

We added the dependency, but them the build was failing due to a circular dependency because the React-ImageManager was dependeing on React-RCTImage.
This dependency is conceptually wrong (a piece of Core should not depend on Library which depends on Core... 😑) and I verified that by removing that dependency the framework continue to build.

Changelog:

[Internal] - Fixed dependencies of Codegen on React-Image

Test Plan

Tested on a local app + CircleCI

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable November 24, 2023 17:29
@cipolleschi cipolleschi changed the title cipolleschi/fix fabric image deps [RN][iOS] Fix React-FabricImage dependencies Nov 24, 2023
@cipolleschi cipolleschi marked this pull request as ready for review November 24, 2023 17:35
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-fabric-image-deps branch from 03c67b0 to 5703bb5 Compare November 24, 2023 17:54
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,518,593 -9,152,042
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,756,753 -11,297,088
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 67c852e
Branch: main

Copy link

github-actions bot commented Nov 24, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 03c67b0

@huntie huntie merged commit 830c2e7 into 0.73-stable Nov 27, 2023
64 checks passed
@cortinico cortinico deleted the cipolleschi/fix-fabric-image-deps branch June 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants