Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude JSI headers when using hermes-engine prebuilt #41499

Closed
wants to merge 1 commit into from
Closed

Exclude JSI headers when using hermes-engine prebuilt #41499

wants to merge 1 commit into from

Commits on Nov 16, 2023

  1. Do not include two copies of JSI when using hermes-engine (facebook#4… 

    …1499)

Summary:

After D48152876 we consume JSI from `ReactCommon/jsi`, and ignore JSI that is distributed with `hermes-engine`.
This diff removes `include/jsi` from `source_files` of `hermes-engine` so we don't get two sets of JSI headers - one from `ReactCommon`, and the other one from `hermes-engine`.
This diff also fixes accidental breakage of ODR violation. We will no longer compile JSI into `react-native` when linking against `hermes-engine`, which already has JSI in it.
Changelog: [iOS][Fixed] - Exclude JSI headers when using hermes-engine prebuilt.

Reviewed By: cipolleschi

Differential Revision: D51347562
    @dmytrorykun @facebook-github-bot
    dmytrorykun authored and facebook-github-bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b8fed1d View commit details
    Browse the repository at this point in the history